[webkit-changes] [WebKit/WebKit] ea774f: REGRESSION(273934 at main): [ Debug ] Multiple layout...

Tim Nguyen noreply at github.com
Fri Feb 2 12:56:08 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ea774f9f202d62eb8a4d7047d18dfb5666ffe784
      https://github.com/WebKit/WebKit/commit/ea774f9f202d62eb8a4d7047d18dfb5666ffe784
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-02-02 (Fri, 02 Feb 2024)

  Changed paths:
    M Source/WebCore/page/LocalDOMWindow.cpp

  Log Message:
  -----------
  REGRESSION(273934 at main): [ Debug ] Multiple layout tests crashing.
https://bugs.webkit.org/show_bug.cgi?id=268650
rdar://122199019

Reviewed by Matthieu Dubet.

This restores the behavior pre-273934 at main when getting the computed style of pseudo-elements like "::placeholder" / "::file-selector-button".

getComputedStyle() support for these pseudo-elements is currently broken (and has always been), since we return the element style instead, but this change
makes it so we stop asserting.

* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::getComputedStyle const):

Canonical link: https://commits.webkit.org/274010@main




More information about the webkit-changes mailing list