[webkit-changes] [WebKit/WebKit] 785821: AX: Crash in AXIsolatedTree::removeNode due to upd...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7858210211c2803cb7dc4397e438242bb0dfff7c
      https://github.com/WebKit/WebKit/commit/7858210211c2803cb7dc4397e438242bb0dfff7c
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2024-02-02 (Fri, 02 Feb 2024)

  Changed paths:
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h

  Log Message:
  -----------
  AX: Crash in AXIsolatedTree::removeNode due to update of relations triggering a layout.
https://bugs.webkit.org/show_bug.cgi?id=268429
<rdar://problem/121976907>

Reviewed by Tyler Wilcock.

The AccessibilityObject::isLabel method causes a relations update, that in turn triggers a layout update while building isolated objects, and thus causing a crash. This patch fixes the problem by determining whether the object that is being removed is a label for other objects without updating the relations.

* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::updateIsolatedTree):
(WebCore::AXObjectCache::updateIsolatedTree const):
(WebCore::AXObjectCache::relatedObjectIDsFor):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updatePropertiesForSelfAndDescendants):
(WebCore::AXIsolatedTree::updateDependentProperties):
(WebCore::AXIsolatedTree::removeNode):
(WebCore::AXIsolatedTree::queueNodeUpdate):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:

Canonical link: https://commits.webkit.org/274003@main