[webkit-changes] [WebKit/WebKit] f24a54: [WebGPU] Fix flaky crashing tests

mwyrzykowski noreply at github.com
Fri Feb 2 10:49:29 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f24a54ed74e22e90eb6db78c256d70ffc1a0855f
      https://github.com/WebKit/WebKit/commit/f24a54ed74e22e90eb6db78c256d70ffc1a0855f
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-02-02 (Fri, 02 Feb 2024)

  Changed paths:
    M Source/WebGPU/WebGPU/PipelineLayout.h
    M Source/WebGPU/WebGPU/PipelineLayout.mm
    M Source/WebGPU/WebGPU/Queue.h
    M Source/WebGPU/WebGPU/Queue.mm
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm
    M Source/WebGPU/WebGPU/RenderPipeline.h
    M Source/WebGPU/WebGPU/RenderPipeline.mm

  Log Message:
  -----------
  [WebGPU] Fix flaky crashing tests
https://bugs.webkit.org/show_bug.cgi?id=268628
<radar://122189307>

Reviewed by Tadeu Zagallo.

The member variable, m_device, was being accessed off a single
thread, in scheduleWork(), so it should be ThreadSafeWeakPtr
instead of WeakPtr.

* Source/WebGPU/WebGPU/Queue.h:
* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::commitMTLCommandBuffer):
(WebGPU::Queue::submit):
(WebGPU::Queue::writeBuffer):
(WebGPU::Queue::device const):
(WebGPU::Queue::clearTexture):
(WebGPU::Queue::writeTexture):
(WebGPU::Queue::scheduleWork):

* Source/WebGPU/WebGPU/PipelineLayout.h:
* Source/WebGPU/WebGPU/PipelineLayout.mm:
(WebGPU::PipelineLayout::errorValidatingBindGroupCompatibility const):
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::executePreDrawCommands):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::executePreDrawCommands):
* Source/WebGPU/WebGPU/RenderPipeline.h:
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::RenderPipeline::vertexStageInBufferCount const):
Fix improper validation logic introduced with
https://bugs.webkit.org/show_bug.cgi?id=267285

Canonical link: https://commits.webkit.org/274001@main




More information about the webkit-changes mailing list