[webkit-changes] [WebKit/WebKit] 870d68: AX: Missing nullptr check for parentObjectUnignore...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 870d68c0876919feb0e5bfb95f81f263a7f18c47
      https://github.com/WebKit/WebKit/commit/870d68c0876919feb0e5bfb95f81f263a7f18c47
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-02-01 (Thu, 01 Feb 2024)

  Changed paths:
    M LayoutTests/accessibility-isolated-tree/TestExpectations
    A LayoutTests/accessibility/menuitem-is-selected-expected.txt
    A LayoutTests/accessibility/menuitem-is-selected.html
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp

  Log Message:
  -----------
  AX: Missing nullptr check for parentObjectUnignored in AccessibilityObject::isSelected()
https://bugs.webkit.org/show_bug.cgi?id=268509
rdar://121945437

Reviewed by Chris Fleizach and Andres Gonzalez.

parentObjectUnignored() can return nullptr, we need to check it before deferencing to avoid a crash.

* LayoutTests/accessibility-isolated-tree/TestExpectations:
Skip new test, as it exposes a bug that affects ITM.
* LayoutTests/accessibility/menuitem-is-selected-crash-expected.txt: Added.
* LayoutTests/accessibility/menuitem-is-selected-crash.html: Added.
* LayoutTests/platform/glib/TestExpectations: Skip new test.
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored const):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isSelected const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::processQueuedNodeUpdates):
Drive-by fix to remove unnecessary HashMap::contains check, HashMap::ensure inherently does this
so the contains check was wasted work.

Canonical link: https://commits.webkit.org/273971@main