[webkit-changes] [WebKit/WebKit] e15eaf: [WebGPU] api, validation, encoding, * is failing

mwyrzykowski noreply at github.com
Thu Feb 1 18:35:55 PST 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e15eaf54e016dd9309122ea662c664a5d8ae10a6
      https://github.com/WebKit/WebKit/commit/e15eaf54e016dd9309122ea662c664a5d8ae10a6
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-02-01 (Thu, 01 Feb 2024)

  Changed paths:
    M LayoutTests/http/tests/webgpu/common/util/util.js
    M LayoutTests/http/tests/webgpu/webgpu/api/operation/adapter/requestDevice-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/operation/adapter/requestDevice.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/beginComputePass-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/beginComputePass.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/beginRenderPass-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/beginRenderPass.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/clearBuffer-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/clearBuffer.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/compute_pass-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/compute_pass.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/copyBufferToBuffer-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/copyBufferToBuffer.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/copyTextureToTexture-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/copyTextureToTexture.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/debug-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/debug.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/index_access-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/index_access.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/draw-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/draw.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/dynamic_state-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/dynamic_state.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/indirect_draw-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/indirect_draw.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/render.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/setIndexBuffer-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/setIndexBuffer.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/setPipeline-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/setPipeline.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/setVertexBuffer-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/setVertexBuffer.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/state_tracking-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/state_tracking.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render_pass-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render_pass.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/setBindGroup-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/setBindGroup.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/createRenderBundleEncoder-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/createRenderBundleEncoder.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/encoder_open_state-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/encoder_open_state.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/encoder_state-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/encoder_state.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/programmable/pipeline_bind_group_compat-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/programmable/pipeline_bind_group_compat.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/queries/begin_end-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/queries/begin_end.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/queries/common.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/queries/general-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/queries/general.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/queries/pipeline_statistics-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/queries/resolveQuerySet-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/queries/resolveQuerySet.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/render_bundle-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/render_bundle.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/validation_test.js
    M LayoutTests/http/tests/webgpu/webgpu/capability_info.js
    M LayoutTests/http/tests/webgpu/webgpu/util/device_pool.js
    M Source/WebCore/Modules/WebGPU/GPUComputePassEncoder.cpp
    M Source/WebCore/Modules/WebGPU/GPUComputePassEncoder.h
    M Source/WebCore/Modules/WebGPU/GPURenderBundleEncoder.cpp
    M Source/WebCore/Modules/WebGPU/GPURenderBundleEncoder.h
    M Source/WebCore/Modules/WebGPU/GPURenderEncoderBase.idl
    M Source/WebCore/Modules/WebGPU/GPURenderPassDescriptor.h
    M Source/WebCore/Modules/WebGPU/GPURenderPassEncoder.cpp
    M Source/WebCore/Modules/WebGPU/GPURenderPassEncoder.h
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.cpp
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderBundleEncoderImpl.cpp
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderBundleEncoderImpl.h
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderPassEncoderImpl.cpp
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderPassEncoderImpl.h
    M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderBundleEncoder.h
    M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassDescriptor.h
    M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassEncoder.h
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
    M Source/WebGPU/WebGPU/BindGroup.h
    M Source/WebGPU/WebGPU/BindGroup.mm
    M Source/WebGPU/WebGPU/BindGroupLayout.h
    M Source/WebGPU/WebGPU/BindGroupLayout.mm
    M Source/WebGPU/WebGPU/Buffer.h
    M Source/WebGPU/WebGPU/Buffer.mm
    M Source/WebGPU/WebGPU/CommandBuffer.h
    M Source/WebGPU/WebGPU/CommandBuffer.mm
    M Source/WebGPU/WebGPU/CommandEncoder.h
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    M Source/WebGPU/WebGPU/CommandsMixin.h
    M Source/WebGPU/WebGPU/CommandsMixin.mm
    M Source/WebGPU/WebGPU/ComputePassEncoder.h
    M Source/WebGPU/WebGPU/ComputePassEncoder.mm
    M Source/WebGPU/WebGPU/Device.h
    M Source/WebGPU/WebGPU/Device.mm
    M Source/WebGPU/WebGPU/HardwareCapabilities.mm
    M Source/WebGPU/WebGPU/PipelineLayout.h
    M Source/WebGPU/WebGPU/PipelineLayout.mm
    M Source/WebGPU/WebGPU/QuerySet.h
    M Source/WebGPU/WebGPU/QuerySet.mm
    M Source/WebGPU/WebGPU/Queue.h
    M Source/WebGPU/WebGPU/Queue.mm
    M Source/WebGPU/WebGPU/RenderBundle.h
    M Source/WebGPU/WebGPU/RenderBundle.mm
    M Source/WebGPU/WebGPU/RenderBundleEncoder.h
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.h
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm
    M Source/WebGPU/WebGPU/RenderPipeline.h
    M Source/WebGPU/WebGPU/RenderPipeline.mm
    M Source/WebGPU/WebGPU/ShaderModule.mm
    M Source/WebGPU/WebGPU/Texture.h
    M Source/WebGPU/WebGPU/Texture.mm
    M Source/WebGPU/WebGPU/TextureView.h
    M Source/WebGPU/WebGPU/TextureView.mm
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.cpp
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.h
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.messages.in
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.cpp
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.h
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.messages.in
    M Source/WebKit/Shared/WebGPU/WebGPURenderPassDescriptor.cpp
    M Source/WebKit/Shared/WebGPU/WebGPURenderPassDescriptor.h
    M Source/WebKit/Shared/WebGPU/WebGPURenderPassDescriptor.serialization.in
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderBundleEncoderProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderBundleEncoderProxy.h
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderPassEncoderProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderPassEncoderProxy.h

  Log Message:
  -----------
  [WebGPU] api,validation,encoding,* is failing
https://bugs.webkit.org/show_bug.cgi?id=267285
<radar://120727214>

Reviewed by Dan Glastonbury.

Add validation and passing expectations for validation,encoding,*
and its 24 test suites.

Also disable timestamps query as the counter sample buffers were sometimes returning
nil and the error message from the debug layer was not useful. Re-enabling is tracked
by https://bugs.webkit.org/show_bug.cgi?id=268244

* LayoutTests/http/tests/webgpu/common/util/util.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/beginComputePass.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/beginRenderPass-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/beginRenderPass.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/clearBuffer-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/clearBuffer.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/compute_pass-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/compute_pass.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/copyBufferToBuffer-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/copyBufferToBuffer.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/copyTextureToTexture-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/copyTextureToTexture.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/debug-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/debug.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/index_access-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/index_access.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/draw.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/dynamic_state-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/dynamic_state.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/indirect_draw-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/indirect_draw.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/render.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/setIndexBuffer-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/setIndexBuffer.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/setPipeline-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/setPipeline.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/setVertexBuffer-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/setVertexBuffer.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/state_tracking-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/state_tracking.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render_pass-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render_pass.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/setBindGroup-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/setBindGroup.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/createRenderBundleEncoder-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/createRenderBundleEncoder.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/encoder_open_state-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/encoder_open_state.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/encoder_state-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/encoder_state.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/programmable/pipeline_bind_group_compat-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/programmable/pipeline_bind_group_compat.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/queries/begin_end-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/queries/begin_end.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/queries/common.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/queries/general-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/queries/general.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/queries/pipeline_statistics-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/queries/resolveQuerySet-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/queries/resolveQuerySet.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/render_bundle-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/render_bundle.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/validation_test.js:
* LayoutTests/http/tests/webgpu/webgpu/capability_info.js:
* LayoutTests/http/tests/webgpu/webgpu/util/device_pool.js:
* Source/WebCore/Modules/WebGPU/GPUComputePassEncoder.cpp:
(WebCore::GPUComputePassEncoder::setBindGroup):
* Source/WebCore/Modules/WebGPU/GPUComputePassEncoder.h:
* Source/WebCore/Modules/WebGPU/GPURenderBundleEncoder.cpp:
(WebCore::GPURenderBundleEncoder::setVertexBuffer):
(WebCore::GPURenderBundleEncoder::setBindGroup):
* Source/WebCore/Modules/WebGPU/GPURenderBundleEncoder.h:
* Source/WebCore/Modules/WebGPU/GPURenderEncoderBase.idl:
* Source/WebCore/Modules/WebGPU/GPURenderPassDescriptor.h:
(WebCore::GPURenderPassDescriptor::convertToBacking const):
* Source/WebCore/Modules/WebGPU/GPURenderPassEncoder.cpp:
(WebCore::GPURenderPassEncoder::setVertexBuffer):
(WebCore::GPURenderPassEncoder::setBindGroup):
* Source/WebCore/Modules/WebGPU/GPURenderPassEncoder.h:
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.cpp:
(WebCore::WebGPU::CommandEncoderImpl::beginRenderPass):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderBundleEncoderImpl.cpp:
(WebCore::WebGPU::RenderBundleEncoderImpl::setVertexBuffer):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderBundleEncoderImpl.h:
* Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderPassEncoderImpl.cpp:
(WebCore::WebGPU::RenderPassEncoderImpl::setVertexBuffer):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderPassEncoderImpl.h:
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderBundleEncoder.h:
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassDescriptor.h:
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassEncoder.h:
* Source/WebGPU/WebGPU/BindGroup.h:
(WebGPU::BindGroup::create):
(WebGPU::BindGroup::isValid const): Deleted.
* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):
(WebGPU::BindGroup::isValid const):
(WebGPU::BindGroup::bindGroupLayout const):
(WebGPU::BindGroup::BindGroup):
(WebGPU::BindGroup::dynamicBuffer const):
* Source/WebGPU/WebGPU/BindGroupLayout.h:
* Source/WebGPU/WebGPU/BindGroupLayout.mm:
(WebGPU::BindGroupLayout::dynamicBufferCount const):
(WebGPU::BindGroupLayout::validateDynamicOffsets const):
(WebGPU::isEqual):
(WebGPU::equalBindingEntries):
(WebGPU::equalEntries):
(WebGPU::BindGroupLayout::errorValidatingBindGroupCompatibility const):
* Source/WebGPU/WebGPU/Buffer.h:
(WebGPU::Buffer::isValid const): Deleted.
* Source/WebGPU/WebGPU/Buffer.mm:
(WebGPU::storageMode):
(WebGPU::Buffer::setCommandEncoder const):
(WebGPU::Buffer::destroy):
(WebGPU::Buffer::unmap):
(WebGPU::Buffer::isValid const):
(WebGPU::Buffer::recomputeMaxIndexValues const):
(WebGPU::Buffer::maxIndex const):
* Source/WebGPU/WebGPU/CommandBuffer.h:
* Source/WebGPU/WebGPU/CommandBuffer.mm:
(WebGPU::CommandBuffer::makeInvalid):
(WebGPU::CommandBuffer::lastError const):
* Source/WebGPU/WebGPU/CommandEncoder.h:
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::~CommandEncoder):
(WebGPU::CommandEncoder::ensureBlitCommandEncoder):
(WebGPU::CommandEncoder::finalizeBlitCommandEncoder):
(WebGPU::errorValidatingTimestampWrites):
(WebGPU::CommandEncoder::errorValidatingComputePassDescriptor const):
(WebGPU::CommandEncoder::beginComputePass):
(WebGPU::CommandEncoder::setExistingEncoder):
(WebGPU::CommandEncoder::endEncoding):
(WebGPU::CommandEncoder::errorValidatingRenderPassDescriptor const):
(WebGPU::createSimplePso):
(WebGPU::CommandEncoder::runClearEncoder):
(WebGPU::CommandEncoder::beginRenderPass):
(WebGPU::CommandEncoder::errorValidatingCopyBufferToBuffer):
(WebGPU::CommandEncoder::copyBufferToBuffer):
(WebGPU::CommandEncoder::copyBufferToTexture):
(WebGPU::CommandEncoder::makeInvalid):
(WebGPU::CommandEncoder::makeSubmitInvalid):
(WebGPU::CommandEncoder::copyTextureToBuffer):
(WebGPU::validateCopyTextureToTexture):
(WebGPU::CommandEncoder::copyTextureToTexture):
(WebGPU::CommandEncoder::clearBuffer):
(WebGPU::CommandEncoder::setLastError):
(WebGPU::CommandEncoder::finish):
(WebGPU::CommandEncoder::insertDebugMarker):
(WebGPU::CommandEncoder::popDebugGroup):
(WebGPU::CommandEncoder::pushDebugGroup):
(WebGPU::validateResolveQuerySet):
(WebGPU::CommandEncoder::resolveQuerySet):
(WebGPU::CommandEncoder::writeTimestamp):
(WebGPU::CommandEncoder::lock):
(WebGPU::CommandEncoder::isLocked const):
(WebGPU::CommandEncoder::isFinished const):
(WebGPU::validateTimestampWrites): Deleted.
(WebGPU::CommandEncoder::validateComputePassDescriptor const): Deleted.
(WebGPU::CommandEncoder::validateRenderPassDescriptor const): Deleted.
* Source/WebGPU/WebGPU/CommandsMixin.h:
* Source/WebGPU/WebGPU/CommandsMixin.mm:
(WebGPU::CommandsMixin::encoderStateName const):
(WebGPU::CommandsMixin::computedSizeOverflows):
* Source/WebGPU/WebGPU/ComputePassEncoder.h:
(WebGPU::ComputePassEncoder::createInvalid):
* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::ComputePassEncoder):
(WebGPU::ComputePassEncoder::~ComputePassEncoder):
(WebGPU::ComputePassEncoder::executePreDispatchCommands):
(WebGPU::ComputePassEncoder::dispatch):
(WebGPU::ComputePassEncoder::runPredispatchIndirectCallValidation):
(WebGPU::ComputePassEncoder::dispatchIndirect): Deleted.
(WebGPU::ComputePassEncoder::endPass): Deleted.
(WebGPU::ComputePassEncoder::insertDebugMarker): Deleted.
(WebGPU::ComputePassEncoder::validatePopDebugGroup const): Deleted.
(WebGPU::ComputePassEncoder::makeInvalid): Deleted.
(WebGPU::ComputePassEncoder::popDebugGroup): Deleted.
(WebGPU::ComputePassEncoder::pushDebugGroup): Deleted.
(WebGPU::setCommandEncoder): Deleted.
(WebGPU::ComputePassEncoder::setBindGroup): Deleted.
(WebGPU::ComputePassEncoder::setPipeline): Deleted.
(WebGPU::ComputePassEncoder::setLabel): Deleted.
(wgpuComputePassEncoderReference): Deleted.
(wgpuComputePassEncoderRelease): Deleted.
(wgpuComputePassEncoderDispatchWorkgroups): Deleted.
(wgpuComputePassEncoderDispatchWorkgroupsIndirect): Deleted.
(wgpuComputePassEncoderEnd): Deleted.
(wgpuComputePassEncoderInsertDebugMarker): Deleted.
(wgpuComputePassEncoderPopDebugGroup): Deleted.
(wgpuComputePassEncoderPushDebugGroup): Deleted.
(wgpuComputePassEncoderSetBindGroup): Deleted.
(wgpuComputePassEncoderSetPipeline): Deleted.
(wgpuComputePassEncoderSetLabel): Deleted.
* Source/WebGPU/WebGPU/Device.h:
* Source/WebGPU/WebGPU/Device.mm:
(WebGPU::Device::Device):
(WebGPU::Device::placeholderBuffer const):
(WebGPU::Device::placeholderTexture const):
* Source/WebGPU/WebGPU/HardwareCapabilities.mm:
(WebGPU::baseCapabilities):
(WebGPU::baseFeatures):
(WebGPU::mergeBaseCapabilities):
* Source/WebGPU/WebGPU/PipelineLayout.h:
* Source/WebGPU/WebGPU/PipelineLayout.mm:
(WebGPU::PipelineLayout::errorValidatingBindGroupCompatibility const):
* Source/WebGPU/WebGPU/QuerySet.h:
* Source/WebGPU/WebGPU/QuerySet.mm:
(WebGPU::Device::createQuerySet):
(WebGPU::QuerySet::QuerySet):
(WebGPU::QuerySet::isValid const):
(WebGPU::QuerySet::isDestroyed const):
(WebGPU::QuerySet::destroy):
(WebGPU::QuerySet::setCommandEncoder const):
* Source/WebGPU/WebGPU/Queue.h:
* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::Queue):
(WebGPU::Queue::encoderForBuffer const):
(WebGPU::Queue::setEncoderForBuffer):
(WebGPU::Queue::commandBufferWithDescriptor):
(WebGPU::Queue::errorValidatingSubmit const):
(WebGPU::Queue::commitMTLCommandBuffer):
(WebGPU::Queue::submit):
(WebGPU::Queue::writeBuffer):
(WebGPU::Queue::writeTexture):
(WebGPU::Queue::validateSubmit const): Deleted.
* Source/WebGPU/WebGPU/RenderBundle.h:
(WebGPU::RenderBundle::create):
(WebGPU::RenderBundle::createInvalid):
* Source/WebGPU/WebGPU/RenderBundle.mm:
(WebGPU::RenderBundle::RenderBundle):
(WebGPU::RenderBundle::drawCount const):
(WebGPU::RenderBundle::lastError const):
* Source/WebGPU/WebGPU/RenderBundleEncoder.h:
(WebGPU::RenderBundleEncoder::createInvalid):
(WebGPU::RenderBundleEncoder::device const):
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::returnIfEncodingIsFinished):
(WebGPU::Device::createRenderBundleEncoder):
(WebGPU::RenderBundleEncoder::RenderBundleEncoder):
(WebGPU::RenderBundleEncoder::makeInvalid):
(WebGPU::RenderBundleEncoder::addResource):
(WebGPU::RenderBundleEncoder::executePreDrawCommands):
(WebGPU::RenderBundleEncoder::draw):
(WebGPU::RenderBundleEncoder::maxVertexBufferIndex const):
(WebGPU::RenderBundleEncoder::maxBindGroupIndex const):
(WebGPU::RenderBundleEncoder::errorValidatingDraw const):
(WebGPU::RenderBundleEncoder::errorValidatingDrawIndexed const):
(WebGPU::RenderBundleEncoder::runIndexBufferValidation):
(WebGPU::RenderBundleEncoder::runVertexBufferValidation):
(WebGPU::RenderBundleEncoder::drawIndexed):
(WebGPU::RenderBundleEncoder::drawIndexedIndirect):
(WebGPU::RenderBundleEncoder::drawIndirect):
(WebGPU::RenderBundleEncoder::endCurrentICB):
(WebGPU::RenderBundleEncoder::validToEncodeCommand const):
(WebGPU::RenderBundleEncoder::finish):
(WebGPU::RenderBundleEncoder::replayCommands):
(WebGPU::RenderBundleEncoder::insertDebugMarker):
(WebGPU::RenderBundleEncoder::popDebugGroup):
(WebGPU::RenderBundleEncoder::pushDebugGroup):
(WebGPU::RenderBundleEncoder::setBindGroup):
(WebGPU::RenderBundleEncoder::setIndexBuffer):
(WebGPU::RenderBundleEncoder::recordCommand):
(WebGPU::RenderBundleEncoder::setPipeline):
(WebGPU::RenderBundleEncoder::setVertexBuffer):
(wgpuRenderBundleEncoderSetVertexBuffer):
* Source/WebGPU/WebGPU/RenderPassEncoder.h:
(WebGPU::RenderPassEncoder::create):
(WebGPU::RenderPassEncoder::createInvalid):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::RenderPassEncoder):
(WebGPU::RenderPassEncoder::~RenderPassEncoder):
(WebGPU::RenderPassEncoder::beginOcclusionQuery):
(WebGPU::RenderPassEncoder::endOcclusionQuery):
(WebGPU::RenderPassEncoder::addResourceToActiveResources):
(WebGPU::RenderPassEncoder::runIndexBufferValidation):
(WebGPU::RenderPassEncoder::runVertexBufferValidation):
(WebGPU::RenderPassEncoder::maxVertexBufferIndex const):
(WebGPU::RenderPassEncoder::maxBindGroupIndex const):
(WebGPU::RenderPassEncoder::errorValidatingAndBindingBuffers):
(WebGPU::RenderPassEncoder::errorValidatingDrawIndexed const):
(WebGPU::RenderPassEncoder::incrementDrawCount):
(WebGPU::RenderPassEncoder::issuedDrawCall const):
(WebGPU::RenderPassEncoder::executePreDrawCommands):
(WebGPU::RenderPassEncoder::draw):
(WebGPU::RenderPassEncoder::drawIndexed):
(WebGPU::RenderPassEncoder::drawIndexedIndirect):
(WebGPU::RenderPassEncoder::drawIndirect):
(WebGPU::RenderPassEncoder::endPass):
(WebGPU::RenderPassEncoder::executeBundles):
(WebGPU::RenderPassEncoder::insertDebugMarker):
(WebGPU::RenderPassEncoder::validatePopDebugGroup const):
(WebGPU::RenderPassEncoder::makeInvalid):
(WebGPU::RenderPassEncoder::popDebugGroup):
(WebGPU::RenderPassEncoder::setBindGroup):
(WebGPU::RenderPassEncoder::setBlendConstant):
(WebGPU::RenderPassEncoder::setIndexBuffer):
(WebGPU::RenderPassEncoder::setPipeline):
(WebGPU::RenderPassEncoder::setScissorRect):
(WebGPU::RenderPassEncoder::setStencilReference):
(WebGPU::RenderPassEncoder::setVertexBuffer):
(WebGPU::RenderPassEncoder::setViewport):
(wgpuRenderPassEncoderSetVertexBuffer):
(WebGPU::RenderPassEncoder::validateBindGroups): Deleted.
* Source/WebGPU/WebGPU/RenderPipeline.h:
(WebGPU::RenderPipeline::create):
(WebGPU::RenderPipeline::requiredBufferIndices const):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::createVertexDescriptor):
(WebGPU::Device::createRenderPipeline):
(WebGPU::RenderPipeline::RenderPipeline):
(WebGPU::RenderPipeline::primitiveTopology const):
(WebGPU::RenderPipeline::stripIndexFormat const):
* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::handleShaderSuccessOrFailure):
* Source/WebGPU/WebGPU/Texture.h:
(WebGPU::Texture::isValid const): Deleted.
* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::destroy):
(WebGPU::Texture::validateImageCopyTexture):
(WebGPU::Texture::isValid const):
* Source/WebGPU/WebGPU/TextureView.h:
(WebGPU::TextureView::isValid const): Deleted.
* Source/WebGPU/WebGPU/TextureView.mm:
(WebGPU::TextureView::isValid const):
(WebGPU::TextureView::destroy):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.cpp:
(WebKit::RemoteRenderBundleEncoder::setVertexBuffer):
(WebKit::RemoteRenderBundleEncoder::unsetVertexBuffer):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.messages.in:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.cpp:
(WebKit::RemoteRenderPassEncoder::setVertexBuffer):
(WebKit::RemoteRenderPassEncoder::unsetVertexBuffer):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.messages.in:
* Source/WebKit/Shared/WebGPU/WebGPURenderPassDescriptor.cpp:
(WebKit::WebGPU::ConvertToBackingContext::convertToBacking):
(WebKit::WebGPU::ConvertFromBackingContext::convertFromBacking):
* Source/WebKit/Shared/WebGPU/WebGPURenderPassDescriptor.h:
* Source/WebKit/Shared/WebGPU/WebGPURenderPassDescriptor.serialization.in:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderBundleEncoderProxy.cpp:
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::setVertexBuffer):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderBundleEncoderProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderPassEncoderProxy.cpp:
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::setVertexBuffer):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderPassEncoderProxy.h:

Canonical link: https://commits.webkit.org/273966@main

More information about the webkit-changes mailing list