[webkit-changes] [WebKit/WebKit] dffba3: AX: Implement AXStartTextMarkerAttribute and AXEnd...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dffba3d2838bbede6722f804db91807f79afe63b
      https://github.com/WebKit/WebKit/commit/dffba3d2838bbede6722f804db91807f79afe63b
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-02-01 (Thu, 01 Feb 2024)

  Changed paths:
    A LayoutTests/accessibility/ax-thread-text-apis/display-contents-end-text-marker-expected.txt
    A LayoutTests/accessibility/ax-thread-text-apis/display-contents-end-text-marker.html
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AXLogger.cpp
    M Source/WebCore/accessibility/AXTextMarker.cpp
    M Source/WebCore/accessibility/AXTextMarker.h
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

  Log Message:
  -----------
  AX: Implement AXStartTextMarkerAttribute and AXEndTextMarkerAttribute off the main-thread
https://bugs.webkit.org/show_bug.cgi?id=267944
rdar://problem/121463431

Reviewed by Andres Gonzalez.

This patch also reimplements findObjectWithRuns in terms of Accessibility::findMatchingObjects, as the old implementation was
implemented in a way that could hit a dead-end despite there being more objects with text runs left to traverse over.
This bug is exercised by newly added testcase ax-thread-text-apis/display-contents-end-text-marker.html.

* LayoutTests/accessibility/ax-thread-text-apis/display-contents-end-text-marker-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/display-contents-end-text-marker.html: Added.
* Source/WebCore/accessibility/AXCoreObject.h: Add AccessibilitySearchKey::HasTextRuns.
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::findObjectWithRuns):
(WebCore::AXTextMarker::findLast const): Added.
(WebCore::AXTextMarker::findMarker const):
Remove redundant RELEASE_ASSERTs.
* Source/WebCore/accessibility/AXTextMarker.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::Accessibility::isAccessibilityObjectSearchMatchAtIndex):
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::sibling const):
Add missing nullptr check that was causing crashes due to its absence.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Canonical link: https://commits.webkit.org/273962@main