[webkit-changes] [WebKit/WebKit] 4d873d: Convert IPC::Signal to the new IPC serialization f...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4d873d064fe0dbd50803406b2ca406342951cf99
      https://github.com/WebKit/WebKit/commit/4d873d064fe0dbd50803406b2ca406342951cf99
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-02-01 (Thu, 01 Feb 2024)

  Changed paths:
    M Source/WebKit/CMakeLists.txt
    M Source/WebKit/DerivedSources-input.xcfilelist
    M Source/WebKit/DerivedSources.make
    M Source/WebKit/Platform/IPC/IPCEvent.h
    A Source/WebKit/Platform/IPC/IPCEvent.serialization.in
    M Source/WebKit/Platform/IPC/darwin/IPCEventDarwin.cpp
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Tools/TestWebKitAPI/Tests/IPC/EventTests.cpp

  Log Message:
  -----------
  Convert IPC::Signal to the new IPC serialization format
https://bugs.webkit.org/show_bug.cgi?id=268393

Reviewed by Matt Woodrow.

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Platform/IPC/IPCEvent.h:
(IPC::Signal::takeSendRight):
(IPC::Signal::semaphore const):
(IPC::Signal::encode): Deleted.
(IPC::Signal::decode): Deleted.
* Source/WebKit/Platform/IPC/IPCEvent.serialization.in: Added.
* Source/WebKit/Platform/IPC/darwin/IPCEventDarwin.cpp:
(IPC::Signal::encode): Deleted.
(IPC::Signal::decode): Deleted.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

* Tools/TestWebKitAPI/Tests/IPC/EventTests.cpp:
The test was encoding a single Signal object on sender side. However,
on recipient side, it was decoding first a uint64_t and then a Signal.
I have no idea why it was trying to decode that uint64_t given that we
don't send one. One of the tests started failing on iOS only when
decoding that uint64_t. As a result, I tried dropping the decoding of
this uint64_t in ALL the tests and they are all still passing.

Canonical link: https://commits.webkit.org/273956@main