[webkit-changes] [WebKit/WebKit] b0b381: [LBSE] Fix pattern related assertion failure in de...

[Nikolas Zimmermann]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b0b381fbd4be23c80220c10f69495eb5fce129e2
      https://github.com/WebKit/WebKit/commit/b0b381fbd4be23c80220c10f69495eb5fce129e2
  Author: Nikolas Zimmermann <nzimmermann at igalia.com>
  Date:   2024-02-01 (Thu, 01 Feb 2024)

  Changed paths:
    A LayoutTests/platform/glib/svg/custom/recursive-pattern-expected.png
    M LayoutTests/platform/glib/svg/custom/recursive-pattern-expected.txt
    M LayoutTests/platform/ios/svg/custom/recursive-pattern-expected.txt
    M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/recursive-pattern-expected.png
    R LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/recursive-pattern-expected.txt
    R LayoutTests/platform/mac-sonoma-wk2-pixel/svg/custom/recursive-pattern-expected.png
    M LayoutTests/platform/mac/svg/custom/recursive-pattern-expected.png
    M LayoutTests/platform/mac/svg/custom/recursive-pattern-expected.txt
    M LayoutTests/svg/custom/recursive-pattern.svg
    M Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp

  Log Message:
  -----------
  [LBSE] Fix pattern related assertion failure in debug builds
https://bugs.webkit.org/show_bug.cgi?id=268488

Reviewed by Rob Buis.

Fix incorrect cycle handling for pattern resources, not correctly taking
chained resource (href/xlink:href references) into account, leading to
the following assertion in debug builds in svg/custom/recursive-pattern.svg
and svg/custom/pattern-content-inheritance-cycle.svg.

Covered by existing tests.

Combined changes:
* LayoutTests/platform/glib/svg/custom/recursive-pattern-expected.png: Added.
* LayoutTests/platform/glib/svg/custom/recursive-pattern-expected.txt:
* LayoutTests/platform/ios/svg/custom/recursive-pattern-expected.txt:
* LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/recursive-pattern-expected.png:
* LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/recursive-pattern-expected.txt: Removed.
* LayoutTests/platform/mac-sonoma-wk2-pixel/svg/custom/recursive-pattern-expected.png: Removed.
* LayoutTests/platform/mac/svg/custom/recursive-pattern-expected.png:
* LayoutTests/platform/mac/svg/custom/recursive-pattern-expected.txt:
* LayoutTests/svg/custom/recursive-pattern.svg:
* Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::prepareFillOperation):
(WebCore::RenderSVGResourcePattern::prepareStrokeOperation):
(WebCore::RenderSVGResourcePattern::createTileImage const):

Canonical link: https://commits.webkit.org/273944@main