[webkit-changes] [WebKit/WebKit] 855d99: FindStringMatches should use a completion handler

Charlie Wolfe noreply at github.com
Thu Feb 1 13:10:22 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 855d9963362fa755941fc549fe12417ac5866757
      https://github.com/WebKit/WebKit/commit/855d9963362fa755941fc549fe12417ac5866757
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-02-01 (Thu, 01 Feb 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.messages.in
    M Source/WebKit/WebProcess/WebPage/FindController.cpp
    M Source/WebKit/WebProcess/WebPage/FindController.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in

  Log Message:
  -----------
  FindStringMatches should use a completion handler
https://bugs.webkit.org/show_bug.cgi?id=268515
rdar://122053187

Reviewed by Alex Christensen.

To prepare for changes to make this work with site isolation, make the FindStringMatches IPC message use
a completion handler and remove the DidFindStringMatches IPC message.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findStringMatches):
(WebKit::WebPageProxy::didFindStringMatches): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findStringMatches):
* Source/WebKit/WebProcess/WebPage/FindController.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::findStringMatches):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:

Canonical link: https://commits.webkit.org/273935@main




More information about the webkit-changes mailing list