[webkit-changes] [WebKit/WebKit] e8e6ce: [threaded-animation-resolution] refactor code indi...

Antoine Quint noreply at github.com
Thu Feb 1 12:37:34 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e8e6ceec1f12b02e96b0a21144449934234a0049
      https://github.com/WebKit/WebKit/commit/e8e6ceec1f12b02e96b0a21144449934234a0049
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-02-01 (Thu, 01 Feb 2024)

  Changed paths:
    M Source/WebCore/animation/CSSPropertyAnimation.cpp
    M Source/WebCore/platform/graphics/filters/FilterOperations.cpp
    M Source/WebCore/platform/graphics/filters/FilterOperations.h

  Log Message:
  -----------
  [threaded-animation-resolution] refactor code indicating whether two filter lists can be interpolated to be accessible outside of CSSPropertyAnimation
https://bugs.webkit.org/show_bug.cgi?id=268534

Reviewed by Simon Fraser.

As part of the threaded animation resolution work (bug 250970), we will need to be able to identify
cases where `filter` values cannot be interpolated because it will be both difficult to implement
animation of mis-matching filter lists using the Core Animation API and also because it doesn't
make much sense to run an animation in the UIProcess for values that will not continuously change.

The logic that determines whether two `filter` values can be interpolated is private to `CSSPropertyAnimation`
as it stands. This change exposes it on `FilterOperations` directly which will allow `AcceleratedEffectStack`
as well as its remote counterpart to reason about whether a `filter` animation ought to be accelerated.

* Source/WebCore/animation/CSSPropertyAnimation.cpp:
* Source/WebCore/platform/graphics/filters/FilterOperations.cpp:
(WebCore::FilterOperations::canInterpolate const):
* Source/WebCore/platform/graphics/filters/FilterOperations.h:

Canonical link: https://commits.webkit.org/273932@main




More information about the webkit-changes mailing list