[webkit-changes] [WebKit/WebKit] 0761ec: [GStreamer][WebRTC] Potential critical warnings du...

Philippe Normand noreply at github.com
Thu Feb 1 10:45:27 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0761ec7e59e5d8cfd21de78117d4efd045092e67
      https://github.com/WebKit/WebKit/commit/0761ec7e59e5d8cfd21de78117d4efd045092e67
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-02-01 (Thu, 01 Feb 2024)

  Changed paths:
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h

  Log Message:
  -----------
  [GStreamer][WebRTC] Potential critical warnings due to duplicate sink pads in webrtcbin
https://bugs.webkit.org/show_bug.cgi?id=268462

Reviewed by Xabier Rodriguez-Calvar.

The webrtcbin sink pad template no longer implies mline semantics. Those have been transfered to the
corresponding transceiver. So we can simplify our code and let webrtcbin figure out pad names on its own.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::configureAndLinkSource):
(WebCore::GStreamerMediaEndpoint::requestPad):
(WebCore::GStreamerMediaEndpoint::pickAvailablePayloadType):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h:

Canonical link: https://commits.webkit.org/273924@main




More information about the webkit-changes mailing list