[webkit-changes] [WebKit/WebKit] f8dbeb: Deprecate WKBundlePageFindStringMatches

Charlie Wolfe noreply at github.com
Thu Feb 1 08:46:47 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f8dbeb24802246ee9b34dfac504c27013a215b0b
      https://github.com/WebKit/WebKit/commit/f8dbeb24802246ee9b34dfac504c27013a215b0b
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-02-01 (Thu, 01 Feb 2024)

  Changed paths:
    M LayoutTests/editing/find/cocoa/find-and-replace-adjacent-words.html
    M LayoutTests/editing/find/cocoa/find-and-replace-at-editing-boundary.html
    M LayoutTests/editing/find/cocoa/find-and-replace-basic.html
    M LayoutTests/editing/find/cocoa/find-and-replace-in-subframes.html
    M LayoutTests/editing/find/cocoa/find-and-replace-noneditable-matches.html
    M LayoutTests/editing/find/cocoa/find-and-replace-replacement-text-input-events.html
    M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
    M Tools/WebKitTestRunner/TestInvocation.cpp

  Log Message:
  -----------
  Deprecate WKBundlePageFindStringMatches
https://bugs.webkit.org/show_bug.cgi?id=268526
rdar://122063903

Reviewed by Alex Christensen.

Also make changes to make WebKitTestRunner to send a message to the UI process to keep existing tests
working.

Layout tests previously using the injected bundle API need to wait for a presentation update because
it will no longer be synchronous.

* LayoutTests/editing/find/cocoa/find-and-replace-adjacent-words.html:
* LayoutTests/editing/find/cocoa/find-and-replace-at-editing-boundary.html:
* LayoutTests/editing/find/cocoa/find-and-replace-basic.html:
* LayoutTests/editing/find/cocoa/find-and-replace-in-subframes.html:
* LayoutTests/editing/find/cocoa/find-and-replace-noneditable-matches.html:
* LayoutTests/editing/find/cocoa/find-and-replace-replacement-text-input-events.html:
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageFindStringMatches):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::findStringMatchesFromInjectedBundle): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::findStringMatchesInPage):
* Tools/WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

Canonical link: https://commits.webkit.org/273915@main




More information about the webkit-changes mailing list