[webkit-changes] [WebKit/WebKit] 52bbfe: Google meet video effects have a low frame rate

youennf noreply at github.com
Thu Feb 1 04:23:35 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 52bbfead48be6d9040ca75ef9b911beb89caadd0
      https://github.com/WebKit/WebKit/commit/52bbfead48be6d9040ca75ef9b911beb89caadd0
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2024-02-01 (Thu, 01 Feb 2024)

  Changed paths:
    A LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-capture-out-of-DOM-canvas-webgl-expected.txt
    A LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-capture-out-of-DOM-canvas-webgl.html
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp

  Log Message:
  -----------
  Google meet video effects have a low frame rate
rdar://121257960
https://bugs.webkit.org/show_bug.cgi?id=268455

Reviewed by Dan Glastonbury and Kimmo Kinnunen.

Document::canvasChanged is only triggering a PrepareCanvasesForDisplay update if it is not given a rect.
WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver was passing the whole canvas rect.
We change it to passing std::nullopt instead.

* LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-capture-out-of-DOM-canvas-webgl-expected.txt: Added.
* LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-capture-out-of-DOM-canvas-webgl.html: Added.
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver):

Canonical link: https://commits.webkit.org/273897@main




More information about the webkit-changes mailing list