[webkit-changes] [WebKit/WebKit] e70021: REGRESSION (273804 at main): [ macOS wk1 Debug ] http...

Jean-Yves Avenard noreply at github.com
Thu Feb 1 02:26:36 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e70021fd8743d5ae2174bbf43aaa707dc505b02b
      https://github.com/WebKit/WebKit/commit/e70021fd8743d5ae2174bbf43aaa707dc505b02b
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-02-01 (Thu, 01 Feb 2024)

  Changed paths:
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm

  Log Message:
  -----------
  REGRESSION (273804 at main): [ macOS wk1 Debug ] http/tests/media/video-throttled-load-metadata.html is a constant crash
https://bugs.webkit.org/show_bug.cgi?id=268480
rdar://122025990

Reviewed by Youenn Fablet.

273804 at main incorrectly removed the delayed task removal to perform the operation immediately.
However, this method is called while iterating the HashTable from which we are removing the task causing
the iterator to become invalid.
Re-introduce the delayed operation, add comment in code.

Covered by existing tests.

* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm:
(WebCore::RangeResponseGenerator::giveResponseToTaskIfBytesInRangeReceived):

Canonical link: https://commits.webkit.org/273892@main




More information about the webkit-changes mailing list