[webkit-changes] [WebKit/WebKit] e11ba9: fast/mediastream/getDisplayMedia-max-constraints5....

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e11ba9225da49ccf8e41a68b5f101c424a0aa22c
      https://github.com/WebKit/WebKit/commit/e11ba9225da49ccf8e41a68b5f101c424a0aa22c
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-12-31 (Tue, 31 Dec 2024)

  Changed paths:
    M Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp

  Log Message:
  -----------
  fast/mediastream/getDisplayMedia-max-constraints5.html is flakily crashing
https://bugs.webkit.org/show_bug.cgi?id=285249
rdar://142189100

Reviewed by Chris Dumez.

Crash trace indicates reference to a MockRealtimeVideoSource object is created on a background thread, while the object
is being destroyed on the main thread. The cause is MockRealtimeVideoSource is created and destroyed on main runloop,
while m_emitFrameTimer is created with raw pointer of MockRealtimeVideoSource and non-main runloop (m_emitFrameTimer
will create reference to the object when it is fired on the non-main runloop, see 286015 at main). To fix this, make
m_emitFrameTimer capture ThreadSafeWeakPtr instead.

* Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::m_emitFrameTimer):

Canonical link: https://commits.webkit.org/288344@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications