[webkit-changes] [WebKit/WebKit] 0b8e5e: Move GCC_WARN_NON_VIRTUAL_DESTRUCTOR to CommonBase...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0b8e5ea6809c446d5793706d6958019e4f6716db
      https://github.com/WebKit/WebKit/commit/0b8e5ea6809c446d5793706d6958019e4f6716db
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2024-12-30 (Mon, 30 Dec 2024)

  Changed paths:
    M Configurations/CommonBase.xcconfig
    M Source/JavaScriptCore/Configurations/Base.xcconfig
    M Source/ThirdParty/gmock/Configurations/Base.xcconfig
    M Source/WTF/Configurations/Base.xcconfig
    M Source/WebCore/Configurations/Base.xcconfig
    M Source/WebCore/PAL/Configurations/Base.xcconfig
    M Source/WebCore/PAL/ThirdParty/dav1d/Configurations/Base.xcconfig
    M Source/WebGPU/Configurations/Base.xcconfig
    M Source/WebInspectorUI/Configurations/Base.xcconfig
    M Source/WebKit/Configurations/Base.xcconfig
    M Source/WebKitLegacy/mac/Configurations/Base.xcconfig
    M Source/bmalloc/Configurations/Base.xcconfig
    M Tools/DumpRenderTree/mac/TestRunnerMac.mm
    M Tools/TestRunnerShared/UIScriptContext/UIScriptContext.h
    M Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp
    M Tools/WebGPUPlayground/Configurations/Base.xcconfig
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
    M Tools/lldb/lldbWebKitTester/Configurations/Base.xcconfig

  Log Message:
  -----------
  Move GCC_WARN_NON_VIRTUAL_DESTRUCTOR to CommonBase.xcconfig
<https://bugs.webkit.org/show_bug.cgi?id=285220>
<rdar://142127164>

Reviewed by Mike Wyrzykowski.

* Configurations/CommonBase.xcconfig:
(GCC_WARN_NON_VIRTUAL_DESTRUCTOR): Add.
* Source/JavaScriptCore/Configurations/Base.xcconfig:
(GCC_WARN_NON_VIRTUAL_DESTRUCTOR): Delete.
* Source/ThirdParty/gmock/Configurations/Base.xcconfig:
(GCC_WARN_NON_VIRTUAL_DESTRUCTOR): Delete.
* Source/WTF/Configurations/Base.xcconfig:
(GCC_WARN_NON_VIRTUAL_DESTRUCTOR): Delete.
* Source/WebCore/Configurations/Base.xcconfig:
(GCC_WARN_NON_VIRTUAL_DESTRUCTOR): Delete.
* Source/WebCore/PAL/Configurations/Base.xcconfig:
(GCC_WARN_NON_VIRTUAL_DESTRUCTOR): Delete.
* Source/WebCore/PAL/ThirdParty/dav1d/Configurations/Base.xcconfig:
(GCC_WARN_NON_VIRTUAL_DESTRUCTOR): Delete.
* Source/WebGPU/Configurations/Base.xcconfig:
(GCC_WARN_NON_VIRTUAL_DESTRUCTOR): Delete.
* Source/WebInspectorUI/Configurations/Base.xcconfig:
(GCC_WARN_NON_VIRTUAL_DESTRUCTOR): Delete.
* Source/WebKit/Configurations/Base.xcconfig:
(GCC_WARN_NON_VIRTUAL_DESTRUCTOR): Delete.
* Source/WebKitLegacy/mac/Configurations/Base.xcconfig:
(GCC_WARN_NON_VIRTUAL_DESTRUCTOR): Delete.
* Source/bmalloc/Configurations/Base.xcconfig:
(GCC_WARN_NON_VIRTUAL_DESTRUCTOR): Delete.

* Tools/DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::~TestRunner):
- Use default.
* Tools/TestRunnerShared/UIScriptContext/UIScriptContext.h:
(WTR::UIScriptContextDelegate::UIScriptContextDelegate): Add.
(WTR::UIScriptContextDelegate::~UIScriptContextDelegate): Add.
- Define default constructor and virtual destructor.
* Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
(TestWebKitAPI::MultipleInheritanceBase1::MultipleInheritanceBase1): Add.
(TestWebKitAPI::MultipleInheritanceBase1::~MultipleInheritanceBase1): Add.
(TestWebKitAPI::MultipleInheritanceBase2::MultipleInheritanceBase2): Add.
(TestWebKitAPI::MultipleInheritanceBase2::~MultipleInheritanceBase2): Add.
(TestWebKitAPI::MultipleInheritanceDerived::MultipleInheritanceDerived): Add.
(TestWebKitAPI::MultipleInheritanceDerived::~MultipleInheritanceDerived): Add.
- Define default constructor and virtual destructor.
(TestWebKitAPI::Dog::~Dog):
- Make destructor virtual.
* Tools/WebGPUPlayground/Configurations/Base.xcconfig:
(GCC_WARN_NON_VIRTUAL_DESTRUCTOR): Delete.
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::~TestRunner):
- Use default.
* Tools/lldb/lldbWebKitTester/Configurations/Base.xcconfig:
(GCC_WARN_NON_VIRTUAL_DESTRUCTOR): Delete.

Canonical link: https://commits.webkit.org/288332@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications