[webkit-changes] [WebKit/WebKit] 0b242b: Ensure cell's replaced content doesn't get the wro...

Ahmad Saleem noreply at github.com
Fri Dec 27 15:55:13 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0b242bd089483bbbd12084ce184b0bf8e4688c54
      https://github.com/WebKit/WebKit/commit/0b242bd089483bbbd12084ce184b0bf8e4688c54
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-12-27 (Fri, 27 Dec 2024)

  Changed paths:
    A LayoutTests/fast/table/percent-height-replaced-content-in-cell-expected.txt
    A LayoutTests/fast/table/percent-height-replaced-content-in-cell.html
    A LayoutTests/fast/table/resources/border-image-srgb-color-profile.png
    M Source/WebCore/rendering/RenderTableCell.cpp

  Log Message:
  -----------
  Ensure cell's replaced content doesn't get the wrong width

https://bugs.webkit.org/show_bug.cgi?id=269763
rdar://123658956

Reviewed by Alan Baradlay.

Merge: https://chromium.googlesource.com/chromium/src.git/+/03d66d9ce1e602df26a9d544d9258a88b9194349

We need to make the cell's height unusable for calculating perecent/calc height
against before computing its preferred width, otherwise replaced children may use it
to scale up their intrinsic width.

* Source/WebCore/rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computePreferredLogicalWidths):
* LayoutTests/fast/table/percent-height-replaced-content-in-cell-expected.txt:
* LayoutTests/fast/table/percent-height-replaced-content-in-cell.html:
* LayoutTests/fast/table/resources/border-image-srgb-color-profile.png:

Canonical link: https://commits.webkit.org/288316@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list