[webkit-changes] [WebKit/WebKit] 581e79: [Cleanup] Merge overridingLogicalWidth branches in...

Alan Baradlay noreply at github.com
Wed Dec 25 11:49:35 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 581e7906ae951a17192c5ae134b2454921362952
      https://github.com/WebKit/WebKit/commit/581e7906ae951a17192c5ae134b2454921362952
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-12-25 (Wed, 25 Dec 2024)

  Changed paths:
    M Source/WebCore/rendering/RenderBox.cpp

  Log Message:
  -----------
  [Cleanup] Merge overridingLogicalWidth branches in RenderBox::computeLogicalWidthInFragment
https://bugs.webkit.org/show_bug.cgi?id=285140

Reviewed by Antti Koivisto.

-Flex item with 'overridingLogicalWidth()' is handled separately from the rest of 'overridingLogicalWidth' boxes.
Let's merge these codepaths and move the logic to a lambda called 'logicalWidth".

Add a few more lambdas (treatAsReplaced, usedLogicalWidthLength, shouldIgnoreOverconstrainedMargin) to make computeLogicalWidthInFragment slightly more readable.

* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInFragment const):

Canonical link: https://commits.webkit.org/288289@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list