[webkit-changes] [WebKit/WebKit] 36d40c: [ Sequoia ] TestWebKitAPI.FontManagerTests.ChangeT...

Wenson Hsieh noreply at github.com
Tue Dec 24 17:33:19 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 36d40c7dfd972e688c9c0febea6821825a85d6ac
      https://github.com/WebKit/WebKit/commit/36d40c7dfd972e688c9c0febea6821825a85d6ac
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-12-24 (Tue, 24 Dec 2024)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm

  Log Message:
  -----------
  [ Sequoia ] TestWebKitAPI.FontManagerTests.ChangeTypingAttributesWithInspectorBar is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=280215
rdar://136532193

Reviewed by Aditya Keerthi.

On macOS Sequoia and later, the inspector bar's color well no longer supports alpha by default. In
the inspector bar's UI, there's no way to actually pick a foreground color with an alpha component
that's not fully opaque, so this isn't an issue; however, this failing API test currently sets a
transparent foreground color.

Fix this test by changing it to reflect a legitimate user-facing workflow, by specifying an opaque
color.

* Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm:
(TestWebKitAPI::repr):
(TestWebKitAPI::TEST(FontManagerTests, ChangeTypingAttributesWithInspectorBar)):

Canonical link: https://commits.webkit.org/288283@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list