[webkit-changes] [WebKit/WebKit] 37e47a: [Cleanup] Logical height/width override for flex b...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 37e47ab7627b58c47cd4243f4f33dc33e110d7ef
      https://github.com/WebKit/WebKit/commit/37e47ab7627b58c47cd4243f4f33dc33e110d7ef
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-12-24 (Tue, 24 Dec 2024)

  Changed paths:
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderFlexibleBox.cpp

  Log Message:
  -----------
  [Cleanup] Logical height/width override for flex basis computation has priority over other overrides
https://bugs.webkit.org/show_bug.cgi?id=285100

Reviewed by Antti Koivisto.

1. Do not set override for flex basis when it is auto
2. When flex basis is not auto, use it as the highest priority override

* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalHeight const):
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::ScopedFlexBasisAsFlexItemMainSize::ScopedFlexBasisAsFlexItemMainSize):
(WebCore::ScopedFlexBasisAsFlexItemMainSize::~ScopedFlexBasisAsFlexItemMainSize):

Canonical link: https://commits.webkit.org/288270@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications