[webkit-changes] [WebKit/WebKit] 55d789: Support x86_64 in IPInt

Commit Queue noreply at github.com
Mon Dec 23 16:14:24 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 55d789ff3bf87148459a5bf12aa2b2c5ab547d56
      https://github.com/WebKit/WebKit/commit/55d789ff3bf87148459a5bf12aa2b2c5ab547d56
  Author: Daniel Liu <daniel_liu4 at apple.com>
  Date:   2024-12-23 (Mon, 23 Dec 2024)

  Changed paths:
    M Source/JavaScriptCore/llint/InPlaceInterpreter.asm
    M Source/JavaScriptCore/llint/InPlaceInterpreter64.asm
    M Source/JavaScriptCore/offlineasm/arm64.rb
    M Source/JavaScriptCore/offlineasm/instructions.rb
    M Source/JavaScriptCore/offlineasm/x86.rb
    M Source/JavaScriptCore/wasm/WasmFunctionIPIntMetadataGenerator.cpp
    M Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp
    M Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.cpp
    M Source/JavaScriptCore/wasm/WasmTable.cpp
    M Tools/lldb/debug_ipint.py

  Log Message:
  -----------
  Support x86_64 in IPInt
https://bugs.webkit.org/show_bug.cgi?id=285022
rdar://141823156

Reviewed by Yusuke Suzuki.

Previously, IPInt was not tested on x86_64 systems. This patch fixes a variety of issues
in IPInt on x86_64, mainly register conflicts during calls and fixing loading the address
of labels. This allows IPInt to run on x86_64 systems.

* Source/JavaScriptCore/llint/InPlaceInterpreter.asm:
* Source/JavaScriptCore/llint/InPlaceInterpreter64.asm:
* Source/JavaScriptCore/offlineasm/x86.rb:
* Source/JavaScriptCore/wasm/WasmFunctionIPIntMetadataGenerator.cpp:
(JSC::Wasm::FunctionIPIntMetadataGenerator::addReturnData):
* Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp:
(JSC::Wasm::IPIntGenerator::addArguments):
(JSC::Wasm::gprToIndex):
(JSC::Wasm::IPIntGenerator::addCallCommonData):
(JSC::Wasm::IPIntGenerator::addTailCallCommonData):
* Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.cpp:
(JSC::IPInt::WASM_IPINT_EXTERN_CPP_DECL):
* Source/JavaScriptCore/wasm/WasmTable.cpp:
(JSC::Wasm::FuncRefTable::setFunction):
* Tools/lldb/debug_ipint.py:

Canonical link: https://commits.webkit.org/288261@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list