[webkit-changes] [WebKit/WebKit] 9045d9: Rename margin-trim related code in RenderBlockFlow...

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9045d943edb26a944eb17f26437847933231e6a1
      https://github.com/WebKit/WebKit/commit/9045d943edb26a944eb17f26437847933231e6a1
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2024-12-23 (Mon, 23 Dec 2024)

  Changed paths:
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderLayoutState.cpp
    M Source/WebCore/rendering/RenderLayoutState.h

  Log Message:
  -----------
  Rename margin-trim related code in RenderBlockFlow and RenderLayoutState.
https://bugs.webkit.org/show_bug.cgi?id=284887
rdar://141690746

Reviewed by Alan Baradlay.

Both of these classes contain code related to different types of
"trimming," functionality (e.g. text box trim) besides margin-trim. In
order to make the margin-trim related code less ambiguous, we should
rename it by including margin trim in the name similar to the text box
trimming code.

* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlockChildren):
(WebCore::RenderBlockFlow::trimBlockEndChildrenMargins):
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::collapseMarginsWithChildInfo):
* Source/WebCore/rendering/RenderLayoutState.cpp:
(WebCore::RenderLayoutState::RenderLayoutState):
* Source/WebCore/rendering/RenderLayoutState.h:
(WebCore::RenderLayoutState::RenderLayoutState):
(WebCore::RenderLayoutState::setBlockStartMarginTrimming):
(WebCore::RenderLayoutState::blockStartMarginTrimming const):
(WebCore::RenderLayoutState::setBlockStartTrimming): Deleted.
(WebCore::RenderLayoutState::blockStartTrimming const): Deleted.

Canonical link: https://commits.webkit.org/288252@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications