[webkit-changes] [WebKit/WebKit] 050c5b: AX: AXPropertyName::IsGrabbed is not updated when ...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 050c5b45835674a04049e64ceb07ad7958acb4be
      https://github.com/WebKit/WebKit/commit/050c5b45835674a04049e64ceb07ad7958acb4be
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-12-22 (Sun, 22 Dec 2024)

  Changed paths:
    M LayoutTests/accessibility/gtk/aria-drag-and-drop-expected.txt
    M LayoutTests/accessibility/gtk/aria-drag-and-drop.html
    M LayoutTests/accessibility/mac/aria-drag-drop-expected.txt
    M LayoutTests/accessibility/mac/aria-drag-drop.html
    A LayoutTests/accessibility/mac/dynamic-drag-expected.txt
    A LayoutTests/accessibility/mac/dynamic-drag.html
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/page/EventHandler.cpp
    M Source/WebCore/page/EventHandler.h
    M Tools/DumpRenderTree/AccessibilityUIElement.cpp
    M Tools/DumpRenderTree/AccessibilityUIElement.h
    M Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
    M Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl
    M Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp
    M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm
    M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm
    M Tools/WebKitTestRunner/InjectedBundle/playstation/AccessibilityUIElementPlayStation.cpp
    M Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp

  Log Message:
  -----------
  AX: AXPropertyName::IsGrabbed is not updated when non-aria-grabbed drags happen
https://bugs.webkit.org/show_bug.cgi?id=285070
rdar://141880722

Reviewed by Chris Fleizach.

With this commit, we now AXPropertyName::IsGrabbed when drags happen via pointing device or JavaScript.

AccessibilityUIElement::ariaIsGrabbed is renamed to isGrabbed, as this state is not ARIA-only.

* LayoutTests/accessibility/gtk/aria-drag-and-drop-expected.txt:
* LayoutTests/accessibility/gtk/aria-drag-and-drop.html:
* LayoutTests/accessibility/mac/aria-drag-drop-expected.txt:
* LayoutTests/accessibility/mac/aria-drag-drop.html:
* LayoutTests/accessibility/mac/dynamic-drag-expected.txt: Added.
* LayoutTests/accessibility/mac/dynamic-drag.html: Added.
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::onDragElementChanged):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::setDragStateSource const):
(WebCore::EventHandler::dragSourceEndedAt):
(WebCore::EventHandler::updateDragStateAfterEditDragIfNeeded):
(WebCore::EventHandler::handleDrag):
* Source/WebCore/page/EventHandler.h:
* Tools/DumpRenderTree/AccessibilityUIElement.cpp:
(getIsGrabbedCallback):
(AccessibilityUIElement::getJSClass):
(getARIAIsGrabbedCallback): Deleted.
* Tools/DumpRenderTree/AccessibilityUIElement.h:
* Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::isGrabbed const):
(AccessibilityUIElement::ariaIsGrabbed const): Deleted.
* Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::isGrabbed const):
(AccessibilityUIElement::ariaIsGrabbed const): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
(WTR::AccessibilityUIElement::isGrabbed const):
(WTR::AccessibilityUIElement::ariaIsGrabbed const): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::isGrabbed const):
(WTR::AccessibilityUIElement::ariaIsGrabbed const): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::isGrabbed const):
(WTR::AccessibilityUIElement::ariaIsGrabbed const): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/playstation/AccessibilityUIElementPlayStation.cpp:
(WTR::AccessibilityUIElement::isGrabbed const):
(WTR::AccessibilityUIElement::ariaIsGrabbed const): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
(WTR::AccessibilityUIElement::isGrabbed const):
(WTR::AccessibilityUIElement::ariaIsGrabbed const): Deleted.

Canonical link: https://commits.webkit.org/288235@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications