[webkit-changes] [WebKit/WebKit] 9f7de8: state.gov banner text is flowing into body of page

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9f7de82ac8533b6dfc3796581178d3e82f8753d2
      https://github.com/WebKit/WebKit/commit/9f7de82ac8533b6dfc3796581178d3e82f8753d2
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-12-22 (Sun, 22 Dec 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/empty-flex-box-and-margin-collapsing-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/empty-flex-box-and-margin-collapsing-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/empty-flex-box-and-margin-collapsing.html
    M Source/WebCore/rendering/RenderElement.cpp

  Log Message:
  -----------
  state.gov banner text is flowing into body of page
https://bugs.webkit.org/show_bug.cgi?id=285074
<rdar://141370139>

Reviewed by Antti Koivisto.

Both grid and flex boxes establish new formatting contexts. Their margins in block direction don't collapse through.

* LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/empty-flex-box-and-margin-collapsing-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/empty-flex-box-and-margin-collapsing-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/empty-flex-box-and-margin-collapsing.html: Added.
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::createsNewFormattingContext const):

Canonical link: https://commits.webkit.org/288230@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications