[webkit-changes] [WebKit/WebKit] a29ef3: AX: AXIsolatedTree::m_selectedTextMarkerRange is n...

Tyler Wilcock noreply at github.com
Sat Dec 21 14:41:04 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a29ef3b109619cc942baf10a3e19d4e35725fe63
      https://github.com/WebKit/WebKit/commit/a29ef3b109619cc942baf10a3e19d4e35725fe63
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-12-21 (Sat, 21 Dec 2024)

  Changed paths:
    M LayoutTests/accessibility/textarea-insertion-point-line-number.html
    M Source/WebCore/accessibility/AXTextMarker.cpp
    M Source/WebCore/accessibility/AXTextMarker.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp

  Log Message:
  -----------
  AX: AXIsolatedTree::m_selectedTextMarkerRange is not initialized when the tree is created, causing accessibility/textarea-insertion-point-line-number.html to fail in ITM
https://bugs.webkit.org/show_bug.cgi?id=285068
rdar://141876835

Reviewed by Chris Fleizach.

When creating an AXIsolatedTree, we didn't sync the current frame selection into AXIsolatedTree::m_selectedTextMarkerRange,
meaning it would be wrong until it changed again. This commit syncs the frame selection when creating the tree, ensuring
m_selectedTextMarkerRange is right from the start.

* LayoutTests/accessibility/textarea-insertion-point-line-number.html:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::create):

Canonical link: https://commits.webkit.org/288225@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list