[webkit-changes] [WebKit/WebKit] 41ea61: text-spacing: text-autospace: handle combining marks

[Vitor Roriz]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 41ea61ca1ed39dbad7dd08a24d86d8158a6dabed
      https://github.com/WebKit/WebKit/commit/41ea61ca1ed39dbad7dd08a24d86d8158a6dabed
  Author: Vitor Roriz <vitor.roriz at apple.com>
  Date:   2024-12-20 (Fri, 20 Dec 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-autospace/text-autospace-combining-marks-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-autospace/text-autospace-combining-marks-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-autospace/text-autospace-combining-marks.html
    M Source/WTF/wtf/text/CharacterProperties.h
    M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp
    M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h
    M Source/WebCore/platform/graphics/ComplexTextController.cpp

  Log Message:
  -----------
  text-spacing: text-autospace: handle combining marks
https://bugs.webkit.org/show_bug.cgi?id=284979
rdar://133797833

Reviewed by Ryan Reno.

When a combining mark is present, we should consider its base character
for analyzing the character class for text-autospace.

* LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-autospace/text-autospace-combining-marks-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-autospace/text-autospace-combining-marks.html: Added.
* Source/WTF/wtf/text/CharacterProperties.h:
(WTF::isCombiningMark):
* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::InlineItemsBuilder::computeInlineBoxBoundaryTextSpacingsIfNeeded):
(WebCore::Layout::handleTextSpacing):
* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::TextUtil::baseCharacterFromGraphemeCluster):
(WebCore::Layout::TextUtil::lastBaseCharacterFromText):
* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h:
* Source/WebCore/platform/graphics/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

Canonical link: https://commits.webkit.org/288202@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications