[webkit-changes] [WebKit/WebKit] 400325: iOS 18.2 - WebRTC audio input device issues

youennf noreply at github.com
Fri Dec 20 11:51:04 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4003251a646cb7fb1fdbd2a601bb913b1ef9ddb9
      https://github.com/WebKit/WebKit/commit/4003251a646cb7fb1fdbd2a601bb913b1ef9ddb9
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2024-12-20 (Fri, 20 Dec 2024)

  Changed paths:
    M LayoutTests/TestExpectations

  Log Message:
  -----------
  iOS 18.2 - WebRTC audio input device issues
rdar://139797608

Reviewed by Jean-Yves Avenard.

When stopping capture, if audio rendering is ongoing with VPIO, we were setting kAUVoiceIOProperty_MuteOutput to 1.
This is new in 18.2 code base and is in preparation of supporting voice activity detection.

We were correctly setting kAUVoiceIOProperty_MuteOutput back to 0 if we were keeping the same VPIO unit when restarting.
It appears kAUVoiceIOProperty_MuteOutput is sticky so we would need to set kAUVoiceIOProperty_MuteOutput back to 0 on the new unit.

Instead, we are removing the setting of kAUVoiceIOProperty_MuteOutput.
Setting kAUVoiceIOProperty_MuteOutput is useful to enable muted talker detection, which is a future feature, not available in this branch.

There is no such issue in WebKit trunk since, after the fork to this branch, we added explicit mute setting via [AVAudioApplication setInputMuted:error:].

Marking http/wpt/mediasession/voiceActivityDetection.html as failing since we no longer instruct the mock audio unit that the output is muted.

Manually tested on iOS.

* LayoutTests/TestExpectations:
* Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp:
(WebCore::CoreAudioSharedUnit::isProducingMicrophoneSamplesChanged):

Originally-landed-as: 2d1b510c05b1. rdar://141317272
Canonical link: https://commits.webkit.org/288179@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list