[webkit-changes] [WebKit/WebKit] 618273: Ensure RemoteMediaEngineConfigurationFactoryProxy ...
Sihui
noreply at github.com
Fri Dec 20 10:04:24 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 618273ab03038ca00a75e754876a719f2658662a
https://github.com/WebKit/WebKit/commit/618273ab03038ca00a75e754876a719f2658662a
Author: Sihui Liu <sihui_liu at apple.com>
Date: 2024-12-20 (Fri, 20 Dec 2024)
Changed paths:
M Source/WebKit/WebProcess/GPU/media/RemoteMediaEngineConfigurationFactory.cpp
M Source/WebKit/WebProcess/WebProcess.cpp
M Source/WebKit/WebProcess/WebProcess.h
Log Message:
-----------
Ensure RemoteMediaEngineConfigurationFactoryProxy messages are not sent when MediaPlaybackEnabled is false
https://bugs.webkit.org/show_bug.cgi?id=284941
rdar://141733758
Reviewed by Youenn Fablet.
RemoteMediaEngineConfigurationFactoryProxy message endpoints are annotated with MediaPlaybackEnabled, which means
GPU process does not expect to receive these messages when MediaPlaybackEnabled is false. Accordingly, we need to make
sure web process does not send out these messages when MediaPlaybackEnabled is false. This patch implements that by
checking MediaPlaybackEnabled flag value in RemoteMediaEngineConfigurationFactory before sending out message.
* Source/WebKit/WebProcess/GPU/media/RemoteMediaEngineConfigurationFactory.cpp:
(WebKit::RemoteMediaEngineConfigurationFactory::createDecodingConfiguration):
(WebKit::RemoteMediaEngineConfigurationFactory::createEncodingConfiguration):
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::enableMediaPlayback):
* Source/WebKit/WebProcess/WebProcess.h:
Canonical link: https://commits.webkit.org/288168@main
To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications
More information about the webkit-changes
mailing list