[webkit-changes] [WebKit/WebKit] f82c29: AX: Stop unnecessarily exposing AXResolvedEditingS...
Tyler Wilcock
noreply at github.com
Fri Dec 20 09:16:32 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f82c2986a8a4466e232b957bc7a0744a40495471
https://github.com/WebKit/WebKit/commit/f82c2986a8a4466e232b957bc7a0744a40495471
Author: Tyler Wilcock <tyler_w at apple.com>
Date: 2024-12-20 (Fri, 20 Dec 2024)
Changed paths:
A LayoutTests/accessibility/ios-simulator/resolved-text-editing-expected.txt
A LayoutTests/accessibility/ios-simulator/resolved-text-editing.html
R LayoutTests/accessibility/mac/resolved-text-editing-expected.txt
R LayoutTests/accessibility/mac/resolved-text-editing.html
M LayoutTests/platform/mac-wk1/TestExpectations
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm
Log Message:
-----------
AX: Stop unnecessarily exposing AXResolvedEditingStyles on macOS as it's not used by anything
https://bugs.webkit.org/show_bug.cgi?id=284974
rdar://141780735
Reviewed by Chris Fleizach.
The handling of this attribute was added for https://bugs.webkit.org/show_bug.cgi?id=215129 / rdar://65114972,
intending to help fix a bug on iOS. Support for serving this attribute was also added for macOS, but never made use
of by any macOS Apple assistive technology nor any open-source one that I can find, so let's stop exposing it. This
should make accessibilityAttributeValue a bit faster, and more importantly make it clear that we don't have to move
resolvedEditingStyles() off the main-thread for now.
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::resolvedEditingStyles const): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase baseAccessibilityResolvedEditingStyles]):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
Canonical link: https://commits.webkit.org/288164@main
To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications
More information about the webkit-changes
mailing list