[webkit-changes] [WebKit/WebKit] 7f25cf: [ARMv7] Fix WasmAddress testb3

[Justin Michaud]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7f25cfeaf6f216f0526604f90fe9b2bec74253ec
      https://github.com/WebKit/WebKit/commit/7f25cfeaf6f216f0526604f90fe9b2bec74253ec
  Author: Justin Michaud <justin at justinmichaud.com>
  Date:   2024-12-20 (Fri, 20 Dec 2024)

  Changed paths:
    M Source/JavaScriptCore/b3/B3LowerInt64.cpp
    M Source/JavaScriptCore/b3/B3LowerToAir32_64.cpp
    M Source/JavaScriptCore/b3/B3WasmAddressValue.cpp
    M Source/JavaScriptCore/b3/air/AirCustom.cpp
    M Source/JavaScriptCore/b3/air/AirCustom.h
    M Source/JavaScriptCore/b3/testb3_1.cpp
    M Source/JavaScriptCore/b3/testb3_3.cpp
    M Source/JavaScriptCore/b3/testb3_6.cpp
    M Source/JavaScriptCore/b3/testb3_7.cpp
    M Source/JavaScriptCore/b3/testb3_8.cpp
    M Source/JavaScriptCore/b3/testb3_failingArmV7Tests.inc
    M Source/JavaScriptCore/jit/Width.h

  Log Message:
  -----------
  [ARMv7] Fix WasmAddress testb3
https://bugs.webkit.org/show_bug.cgi?id=283938

Reviewed by Yusuke Suzuki.

For now, WasmAddress is only being used by testb3. In the future,
we may want to pin a register on armv7 too, and it was really easy
to make this work, so we just went ahead and did it.

We also comment out some testb3 cases on armv7 using Check, which we aren't
planning to support (until it gets used in WASM).

* Source/JavaScriptCore/b3/B3LowerInt64.cpp:
* Source/JavaScriptCore/b3/B3LowerToAir32_64.cpp:
* Source/JavaScriptCore/b3/B3WasmAddressValue.cpp:
(JSC::B3::WasmAddressValue::WasmAddressValue):
* Source/JavaScriptCore/b3/air/AirCustom.cpp:
(JSC::B3::Air::WasmBoundsCheckCustom::generate):
* Source/JavaScriptCore/b3/air/AirCustom.h:
(JSC::B3::Air::WasmBoundsCheckCustom::forEachArg):
* Source/JavaScriptCore/b3/testb3_1.cpp:
(run):
* Source/JavaScriptCore/b3/testb3_3.cpp:
(addShrTests):
* Source/JavaScriptCore/b3/testb3_6.cpp:
(testLateRegister):
* Source/JavaScriptCore/b3/testb3_7.cpp:
(testPinRegisters):
* Source/JavaScriptCore/b3/testb3_8.cpp:
(testWasmAddressDoesNotCSE):
(testStoreAfterClobberDifferentWidth):
(testStoreAfterClobberDifferentWidthSuccessor):
(testStoreAfterClobberExitsSidewaysSuccessor):
* Source/JavaScriptCore/b3/testb3_failingArmV7Tests.inc:

Canonical link: https://commits.webkit.org/288153@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications