[webkit-changes] [WebKit/WebKit] b96ecd: Declarative Web Push: Move the window context Push...

[Brady Eidson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b96ecd4d82e2ac0f15580a7a1ea7e54b653d3867
      https://github.com/WebKit/WebKit/commit/b96ecd4d82e2ac0f15580a7a1ea7e54b653d3867
  Author: Brady Eidson <beidson at apple.com>
  Date:   2024-12-19 (Thu, 19 Dec 2024)

  Changed paths:
    M LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/DerivedSources-input.xcfilelist
    M Source/WebCore/DerivedSources-output.xcfilelist
    M Source/WebCore/DerivedSources.make
    M Source/WebCore/Headers.cmake
    R Source/WebCore/Modules/push-api/NavigatorPush.idl
    M Source/WebCore/Modules/push-api/PushStrategy.h
    A Source/WebCore/Modules/push-api/WindowPush.idl
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/bindings/js/WebCoreBuiltinNames.h
    M Source/WebCore/page/DOMWindow.cpp
    M Source/WebCore/page/DOMWindow.h
    M Source/WebCore/page/DOMWindow.idl
    M Source/WebCore/page/LocalDOMWindow.cpp
    M Source/WebCore/page/LocalDOMWindow.h
    M Source/WebCore/page/Navigator.cpp
    M Source/WebCore/page/Navigator.h
    M Source/WebCore/page/Navigator.idl
    M Source/WebKit/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebPlatformStrategies.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm

  Log Message:
  -----------
  Declarative Web Push: Move the window context PushManager from Navigator to DOMWindow
rdar://141786288
https://bugs.webkit.org/show_bug.cgi?id=284980

Reviewed by Chris Dumez.

Since our initial implementation, standards work has moved this from window.navigator directly onto window.

* LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Modules/push-api/PushStrategy.h:
* Source/WebCore/Modules/push-api/WindowPush.idl: Renamed from Source/WebCore/Modules/push-api/NavigatorPush.idl.
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
* Source/WebCore/page/DOMWindow.cpp:
* Source/WebCore/page/DOMWindow.h:
* Source/WebCore/page/DOMWindow.idl:
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::m_pushManager):
(WebCore::LocalDOMWindow::pushManager):
(WebCore::toScope):
(WebCore::LocalDOMWindow::subscribeToPushService):
(WebCore::LocalDOMWindow::unsubscribeFromPushService):
(WebCore::LocalDOMWindow::getPushSubscription):
(WebCore::LocalDOMWindow::getPushPermissionState):
(WebCore::ContextDestructionObserver): Deleted.
* Source/WebCore/page/LocalDOMWindow.h:
* Source/WebCore/page/Navigator.cpp:
(WebCore::Navigator::Navigator):
(WebCore::Navigator::pushManager): Deleted.
(WebCore::toScope): Deleted.
(WebCore::Navigator::subscribeToPushService): Deleted.
(WebCore::Navigator::unsubscribeFromPushService): Deleted.
(WebCore::Navigator::getPushSubscription): Deleted.
(WebCore::Navigator::getPushPermissionState): Deleted.
* Source/WebCore/page/Navigator.h:
* Source/WebCore/page/Navigator.idl:
* Source/WebKit/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::windowSubscribeToPushService):
(WebKit::WebPlatformStrategies::windowUnsubscribeFromPushService):
(WebKit::WebPlatformStrategies::windowGetPushSubscription):
(WebKit::WebPlatformStrategies::windowGetPushPermissionState):
(WebKit::WebPlatformStrategies::navigatorSubscribeToPushService): Deleted.
(WebKit::WebPlatformStrategies::navigatorUnsubscribeFromPushService): Deleted.
(WebKit::WebPlatformStrategies::navigatorGetPushSubscription): Deleted.
(WebKit::WebPlatformStrategies::navigatorGetPushPermissionState): Deleted.
* Source/WebKit/WebProcess/WebCoreSupport/WebPlatformStrategies.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:
(TestWebKitAPI::subscribe):
(TestWebKitAPI::getPushSubscription):

Canonical link: https://commits.webkit.org/288144@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications