[webkit-changes] [WebKit/WebKit] b93fde: Add LIFETIME_BOUND to Vector.h methods <https://bu...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b93fdedab723cda3137b3e2bf26411d7900bc1a0
      https://github.com/WebKit/WebKit/commit/b93fdedab723cda3137b3e2bf26411d7900bc1a0
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2024-12-19 (Thu, 19 Dec 2024)

  Changed paths:
    M Source/WTF/wtf/Vector.h
    M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformer.cpp
    M Source/WebCore/Modules/mediastream/SFrameUtils.cpp
    M Source/WebCore/Modules/mediastream/SFrameUtils.h
    M Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp
    M Source/WebCore/platform/win/PasteboardWin.cpp

  Log Message:
  -----------
  Add LIFETIME_BOUND to Vector.h methods <https://bugs.webkit.org/show_bug.cgi?id=280802> <rdar://137175142>

Reviewed by Darin Adler.

Change SFrameCompatibilityPrefixBuffer into a Vector<uint8_t>.

* Source/WTF/wtf/Vector.h:
- Add LIFETIME_BOUND attributes to methods in Vector.h that return
  pointers or references to inner data.

* Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformer.cpp:
(WebCore::RTCRtpSFrameTransformer::encryptFrame):
- Extract std::span from SFrameCompatibilityPrefixBuffer, which is now a
  std::variant.
- Switch to use size() methods on std::span.
- Switch to use memcpySpan() instead of memcpy().
* Source/WebCore/Modules/mediastream/SFrameUtils.cpp:
(WebCore::computeH264PrefixBuffer):
(WebCore::computeVP8PrefixBuffer):
- Update return expressions for std::variant construction.
* Source/WebCore/Modules/mediastream/SFrameUtils.h:
(WebCore::SFrameCompatibilityPrefixBuffer):
- Replace struct SFrameCompatibilityPrefixBuffer with std::variant.
* Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::getURL):
- Fix temporary Vector<wchar_t>.
* Source/WebCore/platform/win/PasteboardWin.cpp:
(WebCore::createGlobalHDropContent): Ditto.

Originally-landed-as: 283286.203 at safari-7620-branch (dbe14535006e). rdar://141322982
Canonical link: https://commits.webkit.org/288142@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications