[webkit-changes] [WebKit/WebKit] 257fce: Only synthesize a 'viewBox' in `<img>` for the doc...

Ahmad Saleem noreply at github.com
Thu Dec 19 17:38:06 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 257fce338020bac6c216a203f092b909cabb9bf9
      https://github.com/WebKit/WebKit/commit/257fce338020bac6c216a203f092b909cabb9bf9
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-12-19 (Thu, 19 Dec 2024)

  Changed paths:
    M LayoutTests/imported/w3c/resources/resource-files.json
    A LayoutTests/imported/w3c/web-platform-tests/svg/embedded/image-embedding-svg-nested-svg-in-foreignobject-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/svg/embedded/image-embedding-svg-nested-svg-in-foreignobject.html
    M LayoutTests/imported/w3c/web-platform-tests/svg/embedded/w3c-import.log
    M Source/WebCore/svg/SVGSVGElement.cpp

  Log Message:
  -----------
  Only synthesize a 'viewBox' in `<img>` for the document element `<svg>`

https://bugs.webkit.org/show_bug.cgi?id=284938
rdar://141733733

Reviewed by Darin Adler.

This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.

Merge: https://chromium.googlesource.com/chromium/src/+/b895b95cbe1718e0492cec48a398e90d26049ed3

SVGSVGElement::currentViewBoxRect() needs to check that it is the
document element as well in the lambda function so it can accordingly
synthesize a `viewBox` in `<img>`.

Upstream Commit (Test Sync): https://github.com/web-platform-tests/wpt/commit/56a3a0687521ab33b98a25ce20f94662671098d8

* Source/WebCore/svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::currentViewBoxRect const):
* LayoutTests/imported/w3c/resources/resource-files.json:
* LayoutTests/imported/w3c/web-platform-tests/svg/embedded/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/svg/embedded/image-embedding-svg-nested-svg-in-foreignobject-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/embedded/image-embedding-svg-nested-svg-in-foreignobject.html:

Canonical link: https://commits.webkit.org/288134@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list