[webkit-changes] [WebKit/WebKit] a957f5: AX: Add support for handling AXFontColorChangeSear...
Tyler Wilcock
noreply at github.com
Thu Dec 19 17:08:30 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a957f500fc729c49e0419ca90debd686790728cb
https://github.com/WebKit/WebKit/commit/a957f500fc729c49e0419ca90debd686790728cb
Author: Tyler Wilcock <tyler_w at apple.com>
Date: 2024-12-19 (Thu, 19 Dec 2024)
Changed paths:
M LayoutTests/accessibility/ax-thread-text-apis/non-collapsed-selection-insertion-point-line-number.html
A LayoutTests/accessibility/ax-thread-text-apis/search-predicate-style-change-expected.txt
A LayoutTests/accessibility/ax-thread-text-apis/search-predicate-style-change.html
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/AccessibilityRenderObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
Log Message:
-----------
AX: Add support for handling AXFontColorChangeSearchKey and AXStyleChangeSearchKey off the main-thread
https://bugs.webkit.org/show_bug.cgi?id=284970
rdar://141774908
Reviewed by Chris Fleizach.
We can compute AXFontColorChangeSearchKey and AXStyleChangeSearchKey using the information we added to serve attributed
strings off the main-thread, so this commit does so, and adds a new test proving we behave correctly.
* LayoutTests/accessibility/ax-thread-text-apis/non-collapsed-selection-insertion-point-line-number.html:
Fix incorrect comment saying this test was a copy of an existing one.
* LayoutTests/accessibility/ax-thread-text-apis/search-predicate-style-change-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/search-predicate-style-change.html: Added.
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::hasSameFontColor):
(WebCore::AccessibilityRenderObject::hasSameStyle):
(WebCore::AccessibilityRenderObject::hasSameFontColor const): Deleted.
(WebCore::AccessibilityRenderObject::hasSameStyle const): Deleted.
* Source/WebCore/accessibility/AccessibilityRenderObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::hasSameFontColor):
(WebCore::AXIsolatedObject::hasSameStyle):
(WebCore::AXIsolatedObject::hasSameFontColor const): Deleted.
(WebCore::AXIsolatedObject::hasSameStyle const): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
Canonical link: https://commits.webkit.org/288129@main
To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications
More information about the webkit-changes
mailing list