[webkit-changes] [WebKit/WebKit] 06fa32: Keeps environmentMapReady promise in pending state...

[Alex Marchenko]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 06fa32413283ac063828168d6fc5ec804c0661e3
      https://github.com/WebKit/WebKit/commit/06fa32413283ac063828168d6fc5ec804c0661e3
  Author: Aleksei Marchenko <aleksei at apple.com>
  Date:   2024-12-19 (Thu, 19 Dec 2024)

  Changed paths:
    M Source/WebCore/Modules/model-element/HTMLModelElement.cpp

  Log Message:
  -----------
  Keeps environmentMapReady promise in pending state after reset.
https://bugs.webkit.org/show_bug.cgi?id=284753
rdar://141467143

Reviewed by Ada Chan.

environmentMapReadyPromise must be in pending state after resetting
environmentMap with an empty string. That behavior matches readyPromise
that signals models source loading.
In this particular fix we check whether a URL for environmentMap is
provided or not before resolving the promise.

There are no changes in LayoutTests/model-element/model-element-environment-map-ready.html
since there is no reliable way to verify that a Promise
is in pending state. The only thing we can do is to make sure
that modelElement.environmentMapReady promise has changed after URL reset.
That verification happens in `<model> rejects the environmentMapReady promise when its environmentMap load is aborted.`

* Source/WebCore/Modules/model-element/HTMLModelElement.cpp:
(WebCore::HTMLModelElement::didFinishEnvironmentMapLoading):

Canonical link: https://commits.webkit.org/288124@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications