[webkit-changes] [WebKit/WebKit] 0bd8e8: getDisplayMedia video track should have non persis...

youennf noreply at github.com
Thu Dec 19 11:51:02 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0bd8e819d75a53ce1d362399efd853856fb4270a
      https://github.com/WebKit/WebKit/commit/0bd8e819d75a53ce1d362399efd853856fb4270a
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2024-12-19 (Thu, 19 Dec 2024)

  Changed paths:
    M LayoutTests/fast/mediastream/get-display-media-settings.html
    A LayoutTests/http/wpt/mediastream/getDisplayMedia-deviceid-persistency-expected.txt
    A LayoutTests/http/wpt/mediastream/getDisplayMedia-deviceid-persistency.html
    M Source/WebCore/platform/mediastream/CaptureDevice.h
    M Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp
    M Source/WebCore/platform/mediastream/gstreamer/MockDisplayCaptureSourceGStreamer.cpp
    M Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp

  Log Message:
  -----------
  getDisplayMedia video track should have non persistent deviceIds
https://bugs.webkit.org/show_bug.cgi?id=284952
rdar://141754036

Reviewed by Eric Carlson.

As per latest meeting and spec change, deviceId persistency should be per document, and not per origin.
Marking screen share capture device as ephemeral to do so.
Also make sure to have capabilities filled properly for deviceId.

* LayoutTests/fast/mediastream/get-display-media-settings.html:
* LayoutTests/http/wpt/mediastream/getDisplayMedia-deviceid-persistency-expected.txt: Added.
* LayoutTests/http/wpt/mediastream/getDisplayMedia-deviceid-persistency.html: Added.
* Source/WebCore/platform/mediastream/CaptureDevice.h:
(WebCore::CaptureDevice::isScreenShareType):
(WebCore::CaptureDevice::CaptureDevice):
* Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp:
(WebCore::DisplayCaptureSourceCocoa::capabilities):
* Source/WebCore/platform/mediastream/gstreamer/MockDisplayCaptureSourceGStreamer.cpp:
(WebCore::MockDisplayCaptureSourceGStreamer::capabilities):
* Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::capabilities):

Canonical link: https://commits.webkit.org/288112@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list