[webkit-changes] [WebKit/WebKit] 5a419d: AX: Serve NSAccessibilityInsertionPointLineNumber ...

Tyler Wilcock noreply at github.com
Thu Dec 19 11:01:20 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a419d49fdf03e29261d419fcc2eec1250f9ab33
      https://github.com/WebKit/WebKit/commit/5a419d49fdf03e29261d419fcc2eec1250f9ab33
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-12-19 (Thu, 19 Dec 2024)

  Changed paths:
    M LayoutTests/accessibility/ax-thread-text-apis/attributed-string/dynamic-style.html
    M LayoutTests/accessibility/ax-thread-text-apis/crash-in-element-for-text-marker.html
    A LayoutTests/accessibility/ax-thread-text-apis/non-collapsed-selection-insertion-point-line-number-expected.txt
    A LayoutTests/accessibility/ax-thread-text-apis/non-collapsed-selection-insertion-point-line-number.html
    A LayoutTests/accessibility/ax-thread-text-apis/search-predicate-font-change-expected.txt
    A LayoutTests/accessibility/ax-thread-text-apis/search-predicate-font-change.html
    M Source/WebCore/accessibility/AXCoreObject.cpp
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AXTextMarker.h
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/accessibility/AccessibilityRenderObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm

  Log Message:
  -----------
  AX: Serve NSAccessibilityInsertionPointLineNumber and AXFontChangeSearchKey off the main-thread
https://bugs.webkit.org/show_bug.cgi?id=284923
rdar://141720178

Reviewed by Chris Fleizach.

NSAccessibilityInsertionPointLineNumber can be computed using the already cached AXIsolatedObject::selectedTextMarkerRange(),
and AXFontChangeSearchKey can be computed using AXPropertyName::Font — this commit does both, and introduces new layout
tests to ensure we behave properly.

* LayoutTests/accessibility/ax-thread-text-apis/attributed-string/dynamic-style.html:
* LayoutTests/accessibility/ax-thread-text-apis/crash-in-element-for-text-marker.html:
* LayoutTests/accessibility/ax-thread-text-apis/non-collapsed-selection-insertion-point-line-number-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/non-collapsed-selection-insertion-point-line-number.html: Added.
* LayoutTests/accessibility/ax-thread-text-apis/search-predicate-font-change-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/search-predicate-font-change.html: Added.
* Source/WebCore/accessibility/AXCoreObject.h:
(WebCore::Accessibility::findUnignoredDescendant):
* Source/WebCore/accessibility/AXTextMarker.h:
(WebCore::AXTextMarkerRange::isCollapsed const):
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::hasSameFont):
(WebCore::AccessibilityRenderObject::hasSameFont const): Deleted.
* Source/WebCore/accessibility/AccessibilityRenderObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
(WebCore::AXIsolatedObject::canBeMultilineTextField):
(WebCore::AXIsolatedObject::insertionPointLineNumber const):
(WebCore::AXIsolatedObject::hasSameFont):
(WebCore::AXIsolatedObject::unobscuredContentRect const): Deleted.
(WebCore::AXIsolatedObject::hasSameFont const): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:
(WebCore::AXIsolatedObject::stylesForAttributedString const):

Canonical link: https://commits.webkit.org/288108@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list