[webkit-changes] [WebKit/WebKit] a7fa91: Expose cookie Partition Key in Web Inspector

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a7fa91e9eceb1305b7b26feb1e3d55bc69b57486
      https://github.com/WebKit/WebKit/commit/a7fa91e9eceb1305b7b26feb1e3d55bc69b57486
  Author: Matthew Finkel <m_finkel at apple.com>
  Date:   2024-12-19 (Thu, 19 Dec 2024)

  Changed paths:
    M Source/JavaScriptCore/inspector/protocol/Page.json
    M Source/WebCore/Headers.cmake
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/inspector/agents/InspectorPageAgent.cpp
    M Source/WebCore/inspector/agents/InspectorPageAgent.h
    M Source/WebCore/loader/CookieJar.cpp
    M Source/WebCore/loader/CookieJar.h
    M Source/WebCore/platform/network/NetworkStorageSession.cpp
    M Source/WebCore/platform/network/NetworkStorageSession.h
    A Source/WebCore/platform/network/ShouldPartitionCookie.h
    M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
    M Source/WebInspectorUI/UserInterface/Models/Cookie.js
    M Source/WebInspectorUI/UserInterface/Views/CookiePopover.js
    M Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js
    M Source/WebInspectorUI/UserInterface/Views/ResourceCookiesContentView.js
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp
    M Source/WebKit/WebProcess/WebPage/WebCookieJar.h

  Log Message:
  -----------
  Expose cookie Partition Key in Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=279980
rdar://136293236

Reviewed by BJ Burg and Devin Rousso.

This patch adds a new column in the cookie storage view that displays a
cookie's partition key. Currently, the column is hidden by default. The
partition key is also shown and can also be set in the popover. However, the
values are not currently plumbed into the underlying cookie stores, so this
change doesn't have any affect on the underlying cookie.

* Source/JavaScriptCore/inspector/protocol/Page.json:
* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/inspector/agents/InspectorPageAgent.cpp:
(WebCore::buildObjectForCookie):
(WebCore::parseCookieObject):
(WebCore::InspectorPageAgent::setCookie):
* Source/WebCore/inspector/agents/InspectorPageAgent.h:
* Source/WebCore/loader/CookieJar.cpp:
(WebCore::CookieJar::setRawCookie):
* Source/WebCore/loader/CookieJar.h:
* Source/WebCore/platform/network/NetworkStorageSession.cpp:
(WebCore::NetworkStorageSession::setCookie):
* Source/WebCore/platform/network/NetworkStorageSession.h:
* Source/WebCore/platform/network/ShouldPartitionCookie.h: Added.
* Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:
* Source/WebInspectorUI/UserInterface/Models/Cookie.js:
(WI.Cookie.parseSetCookieResponseHeader):
(WI.Cookie.prototype.get partitionKey):
(WI.Cookie.prototype.get partitioned):
(WI.Cookie.prototype.equals):
(WI.Cookie.prototype.toProtocol):
(WI.Cookie):
* Source/WebInspectorUI/UserInterface/Views/CookiePopover.js:
(WI.CookiePopover):
(WI.CookiePopover.prototype.get serializedData):
(WI.CookiePopover.prototype.show):
* Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:
(WI.CookieStorageContentView.prototype.initialLayout):
(WI.CookieStorageContentView.prototype._generateSortComparator):
(WI.CookieStorageContentView.prototype._showCookiePopover):
(WI.CookieStorageContentView.prototype.async _willDismissCookiePopover):
(WI.CookieStorageContentView.prototype._formatCookiePropertyForColumn):
(WI.CookieStorageContentView):
* Source/WebInspectorUI/UserInterface/Views/ResourceCookiesContentView.js:
(WI.ResourceCookiesContentView.prototype.tablePopulateCell):
(WI.ResourceCookiesContentView.prototype._refreshResponseCookiesSection):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::setRawCookie):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp:
(WebKit::WebCookieJar::setRawCookie):
* Source/WebKit/WebProcess/WebPage/WebCookieJar.h:

Canonical link: https://commits.webkit.org/288103@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications