[webkit-changes] [WebKit/WebKit] 1c94a7: Make DeprecatedGlobalSettings::builtInNotification...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1c94a76b115abed3ca81fa5a0511af0b33566b70
      https://github.com/WebKit/WebKit/commit/1c94a76b115abed3ca81fa5a0511af0b33566b70
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-12-19 (Thu, 19 Dec 2024)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/page/DeprecatedGlobalSettings.cpp
    M Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
    M Source/WebKit/Shared/WebPreferencesDefaultValues.h

  Log Message:
  -----------
  Make DeprecatedGlobalSettings::builtInNotificationsEnabled() match web preferences value
https://bugs.webkit.org/show_bug.cgi?id=284913
rdar://141647594

Reviewed by Ben Nham.

287881 at main annotates message endpoints with feature flag BuiltInNotificationsEnabled and we started to see some crash
in testing builds, indicating message is received by network process when feature flag is off. This is because web
process is sending the message based on the feature flag value in DeprecatedGlobalSettings, while network process
validates the message with feature flag value in WebPreferences. Normally, these two value should match, but
DeprecatedGlobalSettings::builtInNotificationsEnabled() has a special conditin to get default value from system (
see 282333 at main). To fix the crash, this patch makes WebPreferences get the default value from system, and
DeprecatedGlobalSettings value will always match WebPreferences value.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/page/DeprecatedGlobalSettings.cpp:
(WebCore::DeprecatedGlobalSettings::builtInNotificationsEnabled):
* Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultBuiltInNotificationsEnabled):
* Source/WebKit/Shared/WebPreferencesDefaultValues.h:

Canonical link: https://commits.webkit.org/288101@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications