[webkit-changes] [WebKit/WebKit] b0f069: [cocoa] Add quirk for billpaysite.com

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b0f069e44cd98013c9db57ec2e031111bbcead45
      https://github.com/WebKit/WebKit/commit/b0f069e44cd98013c9db57ec2e031111bbcead45
  Author: Matthew Finkel <m_finkel at apple.com>
  Date:   2024-12-19 (Thu, 19 Dec 2024)

  Changed paths:
    M Source/WebCore/page/Quirks.cpp
    M Source/WebCore/page/Quirks.h
    M Source/WebCore/platform/network/NetworkStorageSession.h
    M Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm
    M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
    M Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.h
    M Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.mm

  Log Message:
  -----------
  [cocoa] Add quirk for billpaysite.com
https://bugs.webkit.org/show_bug.cgi?id=284503
rdar://141328971

Reviewed by Wenson Hsieh.

As a third party, billpaysite.com relies on access to cookies. These cookies
don't need to be first party cookies, because a user typically doesn't interact
with billpaysite.com as a first party. Unfortunately, the site has not adopted
CHIPS yet, either. As a workaround, we can leverage CHIPS and opt the site into
partitioned cookies when it is loaded as a third party.

On Cocoa platforms, we use the _cookieTransform callback where we modify the
cookie's partition key before it is saved in the cookie store.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::needsPartitionedCookies):
* Source/WebCore/page/Quirks.h:
* Source/WebCore/platform/network/NetworkStorageSession.h:
* Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:
(WebCore::NetworkStorageSession::setCookiePartition):
* Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
* Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.mm:
(WebKit::NetworkTaskCocoa::setCookieTransformForFirstPartyRequest):
(WebKit::NetworkTaskCocoa::setCookieTransformForThirdPartyRequest):
(WebKit::NetworkTaskCocoa::setCookieTransform):
(WebKit::NetworkTaskCocoa::willPerformHTTPRedirection):
(WebKit::NetworkTaskCocoa::applyCookiePolicyForThirdPartyCloaking): Deleted.

Canonical link: https://commits.webkit.org/288096@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications