[webkit-changes] [WebKit/WebKit] 9ebe9d: REGRESSION(287835 at main): [CoordinatedGraphics] Scr...

Carlos Garcia Campos noreply at github.com
Thu Dec 19 01:05:42 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9ebe9d89eaef08c00b6fb8749d7fb715b7434cd5
      https://github.com/WebKit/WebKit/commit/9ebe9d89eaef08c00b6fb8749d7fb715b7434cd5
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2024-12-19 (Thu, 19 Dec 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/texmap/coordinated/GraphicsLayerCoordinated.cpp

  Log Message:
  -----------
  REGRESSION(287835 at main): [CoordinatedGraphics] Scrolling by clicking on any scrollbar position is broken
https://bugs.webkit.org/show_bug.cgi?id=284877

Reviewed by Alejandro G. Castro.

This broke in 287835 at main because the CoordinatedPlatformLayer is not
updated when GraphicsLayerCoordinated::syncPosition is called. This is
the expected behavior, the position will be set on
CoordinatedPlatformLayer later when scrolling layers are positioned. The
problem is that GraphicsLayerCoordinated is using the
CoordinatedPlatformLayer properties to compute the layer transform, and
now it's using the previous position, causing a wrong transformed
visible rect to be set in the CoordinatedPlatformLayer. We should use
the GraphicsLayer properties when computing the transforms.

* Source/WebCore/platform/graphics/texmap/coordinated/GraphicsLayerCoordinated.cpp:
(WebCore::GraphicsLayerCoordinated::computeLayerTransformIfNeeded):

Canonical link: https://commits.webkit.org/288079@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list