[webkit-changes] [WebKit/WebKit] 530c20: [WTF] Add LIFETIME_BOUND to URL.h and URLParser.h ...

Commit Queue noreply at github.com
Wed Dec 18 13:16:17 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 530c20b2b4d894913612365036e6857297cbba29
      https://github.com/WebKit/WebKit/commit/530c20b2b4d894913612365036e6857297cbba29
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2024-12-18 (Wed, 18 Dec 2024)

  Changed paths:
    M Source/WTF/wtf/URL.h
    M Source/WTF/wtf/URLParser.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [WTF] Add LIFETIME_BOUND to URL.h and URLParser.h methods
<https://bugs.webkit.org/show_bug.cgi?id=280805>
<rdar://137177574>

Reviewed by Darin Adler.

* Source/WTF/wtf/URL.h:
* Source/WTF/wtf/URLParser.h:
- Add LIFETIME_BOUND attributes to methods that return pointers or
  references to inner data.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::revealFragmentIfNeeded):
- WTF::URL::fragmentIdentifier() returns a StringView, so we must keep
  the URL object alive to fix the use-after-free.  Remove unneeded
  `fragment` variable in favor of `fragmentView`.

Originally-landed-as: 283286.184 at safari-7620-branch (227f601688f4). rdar://141323110
Canonical link: https://commits.webkit.org/288034@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list