[webkit-changes] [WebKit/WebKit] 38909c: AX: Serve NSAccessibilitySelectedTextAttribute off...

Tyler Wilcock noreply at github.com
Wed Dec 18 12:05:10 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 38909c01395f733240beca4a5a93a59242a4d122
      https://github.com/WebKit/WebKit/commit/38909c01395f733240beca4a5a93a59242a4d122
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-12-18 (Wed, 18 Dec 2024)

  Changed paths:
    A LayoutTests/accessibility/ax-thread-text-apis/selected-text-expected.txt
    A LayoutTests/accessibility/ax-thread-text-apis/selected-text.html
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AXTextRun.h
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl
    M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm

  Log Message:
  -----------
  AX: Serve NSAccessibilitySelectedTextAttribute off the main-thread
https://bugs.webkit.org/show_bug.cgi?id=284866
rdar://141663736

Reviewed by Chris Fleizach.

We can already compute selectedTextMarkerRange() off the main-thread, so we can serve NSAccessibilitySelectedTextAttribute
simply by calling AXTextMarkerRange::toString() on that range.

This commit also fixes a bug where AXTextRun::totalLength() didn't check that runs.size() was not zero before indexing
into its runs.

* LayoutTests/accessibility/ax-thread-text-apis/selected-text-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/selected-text.html: Added.
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXTextRun.h:
(WebCore::AXTextRuns::totalLength const):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::selectedTextMarkerRange const):
(WebCore::AccessibilityObject::selectedTextMarkerRange): Deleted.
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::selectedText const):
(WebCore::AXIsolatedObject::selectedTextMarkerRange const):
(WebCore::AXIsolatedObject::selectedTextMarkerRange): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(WTR::AccessibilityUIElement::selectedText):
* Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::selectedText):

Canonical link: https://commits.webkit.org/288030@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list