[webkit-changes] [WebKit/WebKit] bbc7a0: The Overlay Regions flag should be on WKPreference...

Etienne Segonzac noreply at github.com
Wed Dec 18 08:49:09 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bbc7a0a8ee157e7b65ba8934e94e46669ed09049
      https://github.com/WebKit/WebKit/commit/bbc7a0a8ee157e7b65ba8934e94e46669ed09049
  Author: Etienne Segonzac <sgz at apple.com>
  Date:   2024-12-18 (Wed, 18 Dec 2024)

  Changed paths:
    M LayoutTests/overlay-region/fixed-node-updates.html
    M LayoutTests/overlay-region/fixed-overlay-drawn-rect.html
    M LayoutTests/overlay-region/many-candidates.html
    M LayoutTests/overlay-region/map.html
    M LayoutTests/overlay-region/split-scrollers.html
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebKit/UIProcess/API/APIPageConfiguration.h
    M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.h
    M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h
    M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
    M Source/WebKit/mac/replace-webkit-additions-includes.py
    M Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm

  Log Message:
  -----------
  The Overlay Regions flag should be on WKPreferences and not WKWebViewConfiguration
https://bugs.webkit.org/show_bug.cgi?id=284574
<rdar://134291686>

Reviewed by Mike Wyrzykowski.

Move from a WKWebViewConfiguration flag to a (testable) preference.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/UIProcess/API/Cocoa/WKPreferences.h:
* Source/WebKit/mac/replace-webkit-additions-includes.py:
* Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setOverlayRegionsEnabled:]):
(-[WKPreferences _overlayRegionsEnabled]):
* Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:
Add the new preference and a WKA extension point.

* Source/WebKit/UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::overlayRegionsEnabled const): Deleted.
(API::PageConfiguration::setOverlayRegionsEnabled): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration encodeWithCoder:]):
(-[WKWebViewConfiguration initWithCoder:]):
(-[WKWebViewConfiguration _overlayRegionsEnabled]): Deleted.
(-[WKWebViewConfiguration _setOverlayRegionsEnabled:]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
* Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::initializeWebViewConfiguration):
Remove the WKWebViewConfiguration flag.

* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _updateOverlayRegionsForCustomContentView]):
Switch from checking the Configuration to checking the Preference.

* LayoutTests/overlay-region/fixed-node-updates.html:
* LayoutTests/overlay-region/fixed-overlay-drawn-rect.html:
* LayoutTests/overlay-region/many-candidates.html:
* LayoutTests/overlay-region/map.html:
* LayoutTests/overlay-region/split-scrollers.html:
Prepare the tests for when we'll turn the compile time flag on.

Canonical link: https://commits.webkit.org/288012@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list