[webkit-changes] [WebKit/WebKit] 44618e: [WGSL] Emit ids for texture_externals

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 44618effe38365e788addd537e538a9f493f3363
      https://github.com/WebKit/WebKit/commit/44618effe38365e788addd537e538a9f493f3363
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-12-18 (Wed, 18 Dec 2024)

  Changed paths:
    M LayoutTests/fast/webgpu/nocrash/fuzz-282710.html
    M Source/WebCore/Modules/WebGPU/GPUBindGroup.cpp
    M Source/WebCore/Modules/WebGPU/GPUBindGroup.h
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUBindGroupImpl.cpp
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUBindGroupImpl.h
    M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBindGroup.h
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
    M Source/WebGPU/WebGPU/BindGroup.h
    M Source/WebGPU/WebGPU/BindGroup.mm
    M Source/WebGPU/WebGPU/BindGroupLayout.mm
    M Source/WebGPU/WebGPU/CommandBuffer.h
    M Source/WebGPU/WebGPU/CommandEncoder.h
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    M Source/WebGPU/WebGPU/ExternalTexture.h
    M Source/WebGPU/WebGPU/ExternalTexture.mm
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBindGroupProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBindGroupProxy.h

  Log Message:
  -----------
  [WGSL] Emit ids for texture_externals
https://bugs.webkit.org/show_bug.cgi?id=284791
rdar://141529109

Reviewed by Tadeu Zagallo.

We had omitted [[id(K)]] for texture_external types, which results
in OOB shader read at least according to the validation layer.

* LayoutTests/fast/webgpu/nocrash/fuzz-282710.html:
This test detected the error.

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
Emit ids for texture_external.

* Source/WebGPU/WebGPU/BindGroupLayout.mm:
(WebGPU::Device::createBindGroupLayout):
The index was one greater than necessary, but otherwise was not
impacting functionality.

Canonical link: https://commits.webkit.org/288008@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications