[webkit-changes] [WebKit/WebKit] ef7132: MockRealtimeVideoSource creates a ref cycle

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ef713209045c06d14b7a92c69ac1d49d6a5e049f
      https://github.com/WebKit/WebKit/commit/ef713209045c06d14b7a92c69ac1d49d6a5e049f
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2024-12-18 (Wed, 18 Dec 2024)

  Changed paths:
    M Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp

  Log Message:
  -----------
  MockRealtimeVideoSource creates a ref cycle
https://bugs.webkit.org/show_bug.cgi?id=284817
rdar://problem/141616762

Reviewed by Chris Dumez and Phil Normand.

Before the patch MockRealtimeVideoSource would never be destroyed as one of its member, m_emitFrameTimer, was taking a ref to it without ever releasing it.
Instead, we are using a different constructor for m_emitFrameTimer which will only ref MockRealtimeVideoSource when actually using it.

* Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::m_emitFrameTimer):

Canonical link: https://commits.webkit.org/288006@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications