[webkit-changes] [WebKit/WebKit] 0b420f: Use UnixFileDescriptor in IPC and ProcessLauncher

Michael Catanzaro noreply at github.com
Wed Dec 18 04:45:07 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0b420fd88a458a0ba19beeb53b6447b6bfdbbb1c
      https://github.com/WebKit/WebKit/commit/0b420fd88a458a0ba19beeb53b6447b6bfdbbb1c
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2024-12-18 (Wed, 18 Dec 2024)

  Changed paths:
    M Source/WebKit/Platform/IPC/Connection.h
    M Source/WebKit/Platform/IPC/IPCUtilities.h
    M Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp
    M Source/WebKit/Shared/unix/AuxiliaryProcessMain.cpp
    M Source/WebKit/UIProcess/Launcher/ProcessLauncher.cpp
    M Source/WebKit/UIProcess/Launcher/ProcessLauncher.h
    M Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp
    M Source/WebKit/UIProcess/Launcher/playstation/ProcessLauncherPlayStation.cpp

  Log Message:
  -----------
  Use UnixFileDescriptor in IPC and ProcessLauncher
https://bugs.webkit.org/show_bug.cgi?id=280237

Reviewed by Carlos Garcia Campos.

Using UnixFileDescriptor wherever possible makes it harder to
accidentally leak file descriptors.

* Source/WebKit/Platform/IPC/Connection.h:
(IPC::Connection::Identifier::Identifier):
(IPC::Connection::Identifier::operator bool const):
* Source/WebKit/Platform/IPC/IPCUtilities.h:
* Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::socketDescriptor const):
(IPC::Connection::platformInitialize):
(IPC::Connection::platformInvalidate):
(IPC::createPlatformConnection):
(IPC::Connection::createConnectionIdentifierPair):
* Source/WebKit/Shared/unix/AuxiliaryProcessMain.cpp:
* Source/WebKit/UIProcess/Launcher/ProcessLauncher.cpp:
* Source/WebKit/UIProcess/Launcher/ProcessLauncher.h:
* Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:
(WebKit::ProcessLauncher::launchProcess):
(WebKit::ProcessLauncher::platformDestroy): Deleted.
* Source/WebKit/UIProcess/Launcher/playstation/ProcessLauncherPlayStation.cpp:
(WebKit::ProcessLauncher::launchProcess):

Canonical link: https://commits.webkit.org/288001@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list