[webkit-changes] [WebKit/WebKit] c9870e: AX: Serve AXLeftLineTextMarkerRangeForTextMarker, ...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c9870e67e54ff9ed67d6283ae72fcfd1b9e7b2bf
      https://github.com/WebKit/WebKit/commit/c9870e67e54ff9ed67d6283ae72fcfd1b9e7b2bf
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-12-17 (Tue, 17 Dec 2024)

  Changed paths:
    A LayoutTests/accessibility/ax-thread-text-apis/attributed-string/left-line-range-expected.txt
    A LayoutTests/accessibility/ax-thread-text-apis/attributed-string/left-line-range.html
    A LayoutTests/accessibility/ax-thread-text-apis/attributed-string/right-line-range-expected.txt
    A LayoutTests/accessibility/ax-thread-text-apis/attributed-string/right-line-range.html
    A LayoutTests/accessibility/ax-thread-text-apis/style-range-expected.txt
    A LayoutTests/accessibility/ax-thread-text-apis/style-range.html
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AXTextMarker.cpp
    M Source/WebCore/accessibility/AXTextMarker.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl
    M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm

  Log Message:
  -----------
  AX: Serve AXLeftLineTextMarkerRangeForTextMarker, AXRightLineTextMarkerRangeForTextMarker, and AXStyleTextMarkerRangeForTextMarker off the main-thread
https://bugs.webkit.org/show_bug.cgi?id=284564
rdar://141365741

Reviewed by Chris Fleizach.

This commit adds accessibility-thread implementations for these attributes, and adds new layout tests to ensure we
behave correctly.

* LayoutTests/accessibility/ax-thread-text-apis/attributed-string/left-line-range-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/attributed-string/left-line-range.html: Added.
* LayoutTests/accessibility/ax-thread-text-apis/attributed-string/right-line-range-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/attributed-string/right-line-range.html: Added.
* LayoutTests/accessibility/ax-thread-text-apis/style-range-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/style-range.html: Added.
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::AXTextMarker::rangeWithSameStyle const):
(WebCore::AXTextMarker::lineRange const):
(WebCore::AXTextMarker::wordRange const):
(WebCore::AXTextMarker::sentenceRange const):
(WebCore::AXTextMarker::paragraphRange const):
* Source/WebCore/accessibility/AXTextMarker.h:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper lineTextMarkerRangeForTextMarker:forUnit:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::styleTextMarkerRangeForTextMarker):
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::styleTextMarkerRangeForTextMarker):

Canonical link: https://commits.webkit.org/287990@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications