[webkit-changes] [WebKit/WebKit] 744c09: Add more null checks in ResourceLoader::shouldAllo...

Alex Christensen noreply at github.com
Tue Dec 17 14:31:32 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 744c09d76f38f5f524464f07093e8aae2852ac38
      https://github.com/WebKit/WebKit/commit/744c09d76f38f5f524464f07093e8aae2852ac38
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-12-17 (Tue, 17 Dec 2024)

  Changed paths:
    M Source/WebCore/loader/ResourceLoader.cpp

  Log Message:
  -----------
  Add more null checks in ResourceLoader::shouldAllowResourceToAskForCredentials
https://bugs.webkit.org/show_bug.cgi?id=284836
rdar://141633070

Reviewed by Pascoe.

Logs indicate that there's still a null dereference in that function.
I use SecurityContext::securityOrigin instead of Document::securityOrigin
to add a null check if there is no SecurityOrigin.  The proper setting of
SecurityOrigins in all cases isn't done with site isolation on yet.

* Source/WebCore/loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::shouldAllowResourceToAskForCredentials const):

Canonical link: https://commits.webkit.org/287967@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list