[webkit-changes] [WebKit/WebKit] 2ea184: [Screen Time Refactoring] Currently blocked web co...

[Jessica Cheung]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2ea18446ee3b5b205d2d5abc6490fd314c4cc1f8
      https://github.com/WebKit/WebKit/commit/2ea18446ee3b5b205d2d5abc6490fd314c4cc1f8
  Author: Jessica Cheung <jcheung23 at apple.com>
  Date:   2024-12-17 (Tue, 17 Dec 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h
    M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm
    M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
    M Source/WebKit/UIProcess/PageClient.h
    M Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
    M Source/WebKit/UIProcess/mac/PageClientImplMac.mm

  Log Message:
  -----------
  [Screen Time Refactoring] Currently blocked web content briefly visible when navigating away
https://bugs.webkit.org/show_bug.cgi?id=284643
rdar://141447068

Reviewed by Wenson Hsieh.

Currently, switching from blocked URL to unblocked URL will show web content
of blocked URL. This is due to the URL being changed and processed, thus hiding the blocking
view before the new web content has been displayed.
To address this issue, we will now update the ScreenTimeWebpageController's
URL only after a webpage has updated display.

* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm:
(WebKit::PageClientImplCocoa::didChangeScreenTimeWebpageControllerURL):
(WebKit::PageClientImplCocoa::updateScreenTimeWebpageControllerURL):
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::didCommitLayerTree):
* Source/WebKit/UIProcess/PageClient.h:
(WebKit::PageClient::didChangeScreenTimeWebpageControllerURL):
* Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
* Source/WebKit/UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::didCommitLoadForMainFrame):

Canonical link: https://commits.webkit.org/287961@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications